Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misleading message #10944

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Fix misleading message #10944

merged 2 commits into from
Jun 23, 2023

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Jun 19, 2023

Some servers do not provide activities at all. In that case, the label should not read "have activities enabled", because that implies that they could be provided, but are disabled. Which is misleading.

@erikjv erikjv requested review from TheOneRing and fmoc June 19, 2023 15:32
@erikjv erikjv self-assigned this Jun 19, 2023
Some servers do not provide activities at all. In that case, the label
should not read "have activities enabled", because that implies that
they could be provided, but are disabled. Which is misleading.

Fixes: #10814
@erikjv erikjv force-pushed the work/fix-misleading-message branch from d756534 to bde12ef Compare June 19, 2023 15:33
@erikjv erikjv linked an issue Jun 19, 2023 that may be closed by this pull request
2 tasks
Co-authored-by: Hannah von Reth <[email protected]>
@erikjv erikjv requested a review from TheOneRing June 23, 2023 11:34
@TheOneRing TheOneRing merged commit 2e5e0b5 into master Jun 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the work/fix-misleading-message branch June 23, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] ocis accounts don't have Activities enabled
3 participants