Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate white UI text #6581

Closed
ckamm opened this issue Jun 13, 2018 · 7 comments
Closed

Investigate white UI text #6581

ckamm opened this issue Jun 13, 2018 · 7 comments
Assignees
@ckamm
Labels
type:bug
Milestone
2.6.0

Comments

@ckamm
Copy link
Contributor

ckamm commented Jun 13, 2018

Also seen by @SamuAlfageme

image

Some normal ui text is white in this screenshot. Also something is up with the sync scheduling - for me it's stuck in "Preparing to sync" permanently.
@ckamm ckamm added the type:bug label Jun 13, 2018
@ckamm ckamm added this to the 2.5.0 milestone Jun 13, 2018
@ckamm ckamm self-assigned this Jun 13, 2018
@ckamm ckamm mentioned this issue Jun 13, 2018
Closed
@ckamm
Copy link
Contributor Author

ckamm commented Jun 13, 2018

This problem is odd. Using entirely new build directories each time I could initially reproduce it and gradually bisected through the recent commits. Then it was gone and is now also gone on the head of the 2.5 branch, I can not make it appear again.

I would guess at something timing / memory corruption related (why would the text go white?) but don't understand why it's now consistently gone for me.

@ogoffart The patches I thought might be related were 76bb76a and 888f2aa - since not much else changed between 2.5.0-alpha1 and 2.5 - but I don't see anything wrong with them.

@ckamm
Copy link
Contributor Author

ckamm commented Jun 13, 2018 •
edited
Loading

Another recompile without even changing code (just dependencies) and I reproducably get this bug again on startup: (it continues looking like this permanently)

image

@ckamm
Copy link
Contributor Author

ckamm commented Jun 13, 2018

The bug is in 13cb9ab (download doesn't complete) and it was occasionally invisible when the file was blacklisted for a while.

ckamm added a commit that referenced this issue Jun 13, 2018
@ckamm
Ensure GETFileJob notices finishing #6581
d4b448f 
It could happen that readyRead was emitted for incoming data while the
download was not yet finished. Then the network job could finish with
no more data arriving - so readyRead wasn't emitted again.

To fix this, the finished signal also gets connected to the readyRead
slot.
@ckamm ckamm mentioned this issue Jun 13, 2018
Merged
ckamm added a commit that referenced this issue Jun 13, 2018
@ckamm
Ensure GETFileJob notices finishing #6581
709dfbe 
It could happen that readyRead was emitted for incoming data while the
download was not yet finished. Then the network job could finish with
no more data arriving - so readyRead wasn't emitted again.

To fix this, the finished signal also gets connected to the readyRead
slot.
ckamm added a commit that referenced this issue Jun 13, 2018
@ckamm
Ensure GETFileJob notices finishing #6581
ad2446b 
It could happen that readyRead was emitted for incoming data while the
download was not yet finished. Then the network job could finish with
no more data arriving - so readyRead wasn't emitted again.

To fix this, the finished signal also gets connected to the readyRead
slot.
@ckamm ckamm added ReadyToTest QA, please validate the fix/enhancement and removed PR available labels Jun 13, 2018
@ckamm
Copy link
Contributor Author

ckamm commented Jun 13, 2018

@SamuAlfageme fixed in 2.5

@guruz
Copy link
Contributor

guruz commented Jun 27, 2018

Did @SamuAlfageme manage to test this? I remember seeing something about this in an enterprise ticket

Some normal ui text is white in this screenshot.

Where was this fixed?

@ckamm
Copy link
Contributor Author

ckamm commented Jun 27, 2018

The odd white text wasn't fixed. It's possible that could still happen. What was fixed was the sync getting stuck - and with that no white text is visible anymore.

@ckamm ckamm modified the milestones: 2.5.0, 2.6.0 Jul 2, 2018
@ckamm ckamm removed the ReadyToTest QA, please validate the fix/enhancement label Jul 2, 2018
@ckamm ckamm changed the title UI text and sync scheduling bugs in 2.5 branch Investigate white UI text Jul 2, 2018
@camilasan camilasan mentioned this issue Sep 9, 2018
Merged
@ogoffart
Copy link
Contributor

ogoffart commented Dec 4, 2018

White text was fixed in 36ca910

@ogoffart ogoffart closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckamm ckamm

Labels
type:bug
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
3 participants
@ckamm @ogoffart @guruz