Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NSIS Installer] In case of update, do NOT show the choice to remove the data folder. #3461

Closed
dragotin opened this issue Jul 16, 2015 · 3 comments
Assignees
Labels
ReadyToTest QA, please validate the fix/enhancement

Comments

@dragotin
Copy link
Contributor

If somebody gets an auto update, it's pretty obvious that she wants to continue to use ownCloud, and thus does not want to remove the data directory. Is there a way to not show the following installer page if the installer was started from the updater:

rem_datafolder

@dragotin dragotin added this to the next-bugfix-release milestone Jul 16, 2015
danimo pushed a commit that referenced this issue Jul 16, 2015
- This only works for the current user (while being a HKLM installer)
- The naming is confusing.

Fixes #3461
@dragotin dragotin modified the milestones: 2.0 - Multi-account, next-bugfix-release Jul 16, 2015
@danimo
Copy link
Contributor

danimo commented Jul 16, 2015

@dragotin please review

@danimo danimo reopened this Jul 16, 2015
@danimo danimo added the ReadyToTest QA, please validate the fix/enhancement label Jul 16, 2015
@Dianafg76
Copy link

@danimo, I tried this, and I have a doubt. If you have a Destokp v 2.0.0 (build 5230 ) and when actulizas 2.0.0 ( 5289 ) , this appears " Do you want to remove the data folder ownCloud ? " . This is correct?

@Dianafg76
Copy link

@danimo Hello, I tested this issue, and working fine
.- When upgrading a 2.0 pre ownCloud (applies to snapshots past 15.07.2015) to another one or 2.0 alpha, beta, rc or final, you should not see a page in the upgrade wizard offering to remove the application's AppData (see screenshot on original bug for reference).

It is OK

.- When uninstalling 2.0, you should not see a page in the upgrade wizard offering to remove the application's AppData (see screenshot on original bug for reference). When upgrading from 1.8.x or earlier, to a 2.0 snapshot (applies to snapshots past 15.07.2015), alpha, beta, rc or final, you should* see a page in the upgrade wizard offering to remove the application's AppData (see screenshot on original bug for reference). Reason: This dialog is provided by the already installed version.

It is OK

Desktop v ownCloud-2.0.0.5291-nightly20150721-setup.exe

Many thanks, :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReadyToTest QA, please validate the fix/enhancement
Projects
None yet
Development

No branches or pull requests

3 participants