Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCC::SyncEngine::syncFileStatusTracker #11981

Closed
sentry-io bot opened this issue Nov 13, 2024 · 4 comments · Fixed by #11982
Closed

OCC::SyncEngine::syncFileStatusTracker #11981

sentry-io bot opened this issue Nov 13, 2024 · 4 comments · Fixed by #11982
Assignees
@erikjv
Labels
type:bug

Comments

@sentry-io
Copy link

sentry-io bot commented Nov 13, 2024

Sentry Issue: DESKTOP-WIN-AND-MAC-EPB

EXCEPTION_ACCESS_VIOLATION_READ / 0xc0: Fatal Error: EXCEPTION_ACCESS_VIOLATION_READ / 0xc0
  File "syncengine.h", line 99, in OCC::SyncEngine::syncFileStatusTracker
  File "socketapi.cpp", line 957, in OCC::SocketApi::FileData::syncFileStatus
  File "socketapi.cpp", line 485, in OCC::SocketApi::command_RETRIEVE_FILE_STATUS
  File "qmetaobject.cpp", line 2357, in QMetaMethod::invoke
  File "qmetaobject.h", line 90, in QMetaMethod::invoke
...
(27 additional frame(s) were not displayed)
@sentry-io sentry-io bot added the type:bug label Nov 13, 2024
@DeepDiver1975
Copy link
Member

Observable for one year. Quite regular. Seems to start with 5.0 and still present in the latest release. Maybe worth a look. THX @erikjv

erikjv added a commit that referenced this issue Nov 14, 2024
@erikjv
Fix crash when checking the sync file status
3e92647 
Sometimes a `Folder` is created for a local path that we cannot sync
(e.g. it's not writable). This folder will not have a sync engine. If
the engine of this `Folder` is accessed, this will lead to a crash.

The fix is to check for the existance of a sync engine in the
`Folder::canSync()` method.

Fixes: #11981
@erikjv erikjv mentioned this issue Nov 14, 2024
Merged
DeepDiver1975 pushed a commit that referenced this issue Nov 18, 2024
@erikjv
Fix crash when checking the sync file status (#11982)
b65361a 
Sometimes a `Folder` is created for a local path that we cannot sync
(e.g. it's not writable). This folder will not have a sync engine. If
the engine of this `Folder` is accessed, this will lead to a crash.

The fix is to check for the existance of a sync engine in the
`Folder::canSync()` method.

Fixes: #11981
DeepDiver1975 pushed a commit that referenced this issue Nov 29, 2024
@erikjv @DeepDiver1975
Fix crash when checking the sync file status (#11982)
ae34439 
Sometimes a `Folder` is created for a local path that we cannot sync
(e.g. it's not writable). This folder will not have a sync engine. If
the engine of this `Folder` is accessed, this will lead to a crash.

The fix is to check for the existance of a sync engine in the
`Folder::canSync()` method.

Fixes: #11981
@DeepDiver1975 DeepDiver1975 mentioned this issue Nov 29, 2024
Merged
DeepDiver1975 added a commit that referenced this issue Nov 29, 2024
@DeepDiver1975 @erikjv
fix: crash when checking the sync file status (#11982) (#12000)
e04263d 
Sometimes a `Folder` is created for a local path that we cannot sync
(e.g. it's not writable). This folder will not have a sync engine. If
the engine of this `Folder` is accessed, this will lead to a crash.

The fix is to check for the existance of a sync engine in the
`Folder::canSync()` method.

Fixes: #11981

Co-authored-by: Erik Verbruggen <[email protected]>
@PrajwolAmatya
Copy link
Contributor

Can you provide the steps to test this fix.
CC @DeepDiver1975

@DeepDiver1975
Copy link
Member

@erikjv can you answer this please? Thx

@erikjv
Copy link
Collaborator

erikjv commented Dec 19, 2024

@PrajwolAmatya I tried to reproduce it, but I can't. This fix was done by looking at the code and see what could possibly go wrong, and try to prevent that.

So, no testing is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix crash when checking the sync file status owncloud/client
3 participants
@erikjv @DeepDiver1975 @PrajwolAmatya