use auth when waiting for ocis to come online #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
individual-it
requested review from
fschade,
butonic,
dragotin and
pascalwengerter
refs
approved these changes
Jan 17, 2022
wkloucek
approved these changes
Jan 17, 2022
There was a problem hiding this comment.
Looks like the accounts service is not ready when K6 starts. Adding authentication to this wait script will cause the request to be authenticated in the backend, which is only possible when the accounts service is fully ready. Until it will return a 401 Unauthorized - in comparison to a 200 OK for unauthenticated request
|
🧑⚖️ 💥 case closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
who can solve this riddle? After a lot of trying around I found out that the tests break when sending this "waiting" request without username & password, but just adding that makes them pass again.
I could not reproduce the problem when just running a compiled version of ocis, only when running it from docker, but that might be a timing issue.
Maybe related to owncloud/ocis#2964