Upload when charging

[tobiasKaminsky]

See #465

[LukeOwlclaw]

Nice! I just added KEY_WHILE_CHARGING_ONLY to the new FileUploadService (--> https://github.com/owncloud/android/tree/reliable_uploads). It'll take care that upload does not start while discharging. Starting at the right moment is missing still though. I think the broadcast receiver for ACTION_POWER_CONNECTED should go into a separate class (just like BootupBroadcastReceiver). There may be other features to come which also rely in that event.

[tobiasKaminsky]

But this is an option like for instant uploads?
About refactoring: You are right.
Maybe there will be soon other events that can be included in one BrodcastReceiver.
Especially when a more generic instant upload is coming (#744)

[LukeOwlclaw]

But this is an option like for instant uploads?

Yes, it is but it can also be used for other uploads.
The idea is that the InstantUploader just tells the UploadService would to do. So all it does:

Intent i = new Intent(context, FileUploadService.class);
i.putExtra(FileUploadService.KEY_LOCAL_FILE, file_path);
...
i.putExtra(FileUploadService.KEY_WIFI_ONLY, instantPictureUploadViaWiFiOnly(context));
i.putExtra(FileUploadService.KEY_WHILE_CHARGING_ONLY, instantUploadWhenChargingOnly(context));
context.startService(i);

No need to worry about being not connected or not charging. The UploadService will handle that.

[jancborchardt]

@tobiasKaminsky can you post a screenshot of how this looks like so I can design-review it?

[tobiasKaminsky]

Currently there is only one "upload when charging", but two "upload on wifi"...
I do not know what my intention was...

[masensio]

Hi @tobiasKaminsky!

I'm reviewing this PR. The branch is outdated, but don't worry. I will updated it.
I'll cross my fingers when resolve conflicts

[masensio]

Maybe, it is necessary to review the order in the preferences.xml

[tobiasKaminsky]

@jancborchardt can review the order?

[jancborchardt]

Which order is this actually?

[tobiasKaminsky]

@jancborchardt Please have a look here

[jancborchardt]

Looks good! Just a few details:

• can you change the text to »Upload folder«?
• can you change »WiFi« to »wifi«?
• I assume the folder, wifi and charging options are greyed out when the main instant upload option is not enabled?

[tobiasKaminsky]

ref 1:"Upload folder"? We do not support this currently, or?
This is all about the option, that the upload only starts if the phone is charging.

2: I will change
3: As far as I remember, they are not visible, if the main option is disabled.
--> they are greyed out

[jancborchardt]

@tobiasKaminsky right, if we call it »Upload folder« it might get confusing. »Upload path« is better, but with »path« in lowercase.

[tobiasKaminsky]

Should "when charging" be independent for picture and video as "on wifi"?

[tobiasKaminsky]

Updated text:

@jancborchardt Remaining question is, if "when charging" should be an independent setting for picture and video? This could be a good idea as videos are very big and can drain the battery very quick...

[jancborchardt]

@tobiasKaminsky yeah, I would make the setting independent. Right now on the very top it’s kind of confusing anyway.

[tobiasKaminsky]

[jancborchardt]

Yeah, looks good!

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tobiasKaminsky
❌ masensio

---

masensio seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}