Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Correct label for each activities and fragments #4470

Merged
merged 10 commits into from
Sep 24, 2024

Conversation

Aitorbp
Copy link
Contributor

@Aitorbp Aitorbp commented Sep 18, 2024

Related Issues

App: #4458

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@Aitorbp Aitorbp self-assigned this Sep 18, 2024
@Aitorbp Aitorbp linked an issue Sep 18, 2024 that may be closed by this pull request
9 tasks
@Aitorbp Aitorbp force-pushed the feature/correct_label_for_each_activities_fragments branch from c78a272 to 1dd58d5 Compare September 19, 2024 06:44
@Aitorbp Aitorbp requested a review from JuancaG05 September 19, 2024 06:52
@JuancaG05 JuancaG05 changed the title Correct label for each activities and fragments [a11y] Correct label for each activities and fragments Sep 19, 2024
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested here @Aitorbp

@Aitorbp Aitorbp force-pushed the feature/correct_label_for_each_activities_fragments branch 2 times, most recently from 83c63ad to acf97ae Compare September 19, 2024 09:06
@Aitorbp Aitorbp requested a review from JuancaG05 September 19, 2024 09:09
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, moving to QA

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 23, 2024

As far a i can see, these are the affected views:

Folder picker ✅
Passcode ✅
Pattern ✅
Receive external files ✅
Video preview ✅
Release notes ✅
Image preview ✅
Login ✅
What's new ✅
Audio preview ✅ - detected problem in playing -> #4474
Details ✅
Text preview ✅

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 24, 2024

The problem with the audio preview only happens in Android 14. Checked with a device in an older Android version and works

@jesmrec jesmrec force-pushed the feature/correct_label_for_each_activities_fragments branch from 0329aaa to 23397dd Compare September 24, 2024 11:46
@jesmrec jesmrec merged commit 78414e1 into master Sep 24, 2024
7 checks passed
@jesmrec jesmrec deleted the feature/correct_label_for_each_activities_fragments branch September 24, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y] Correct label for each activities and fragments
3 participants