[BUG] Fix display name truncation issue with ellipsis #4380
Conversation
Resolved the bug where long display names were truncated incorrectly in the Manage Accounts view. Now, display names are properly truncated in the middle with ellipsis (...) to maintain readability. Fixes #4351
|
|
|
Thanks a lot for you contribution @Prakhar1701. Now, the team will review it and give you some feedback from code and QA points of view. |
There was a problem hiding this comment.
Nice job here @Prakhar1701! Thanks for your contribution 😄
Just one more thing, do you dare to add the Calens file and the release note so that users will be informed about this improvement in the next release? Details are in the template you used for this pull request, in the first message you added. If you have any question just ask us 🚀
|
@JuancaG05 I have added the Calens file and the release note, please check. |
There was a problem hiding this comment.
Hi @Prakhar1701! Nice work! Just 2 tiny things about the format of Calens and release note files 😄
|
Thanks @JuancaG05 for guiding me with the correct format of the files. |
There was a problem hiding this comment.
Good job @Prakhar1701! This is approved from my side. Thanks again for your contribution 😄. Now this PR will pass a QA round, done by @jesmrec, and if there is any kind of flaw, he will let you know 🚀.
BTW, if you contribute in the future with other PR (we will be happy to see you over here 🥳), would be nice if you use conventional commits naming, just as explained here 👍.
|
Let's QA this |
(1) [FIXED]I notice that the text is not adapting somehow to the existing room. For example, this user:
It is shown correctly in portrait orientation:
but, in landscape:
the circled area in white gives enough room to show more information. Could you take a look? Pixel2, Android11 |
|
@jesmrec I have resolved the mentioned issue, please check. |
|
Fixed, thanks @Prakhar1701 ! |
|
Let's move this forward. Approved |
Resolved the bug where long display names were truncated incorrectly in the Manage Accounts view. Now, display names are properly truncated in the middle with ellipsis (...) to maintain readability.
Fixes #4351
Related Issues
App:
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA