Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify commit messages in calens and dependabot to fit "Conventional commits" #4346

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Mar 19, 2024

More info:

https://www.conventionalcommits.org/en/v1.0.0/#summary

Calens commits to add docs: as prefix
Dependabot commits to add feat: as prefix

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec self-assigned this Mar 19, 2024
@jesmrec jesmrec force-pushed the feature/adapt_3rd_party_apps_to_conventional_commits branch 3 times, most recently from 792c2b9 to f161e37 Compare March 19, 2024 13:39
@jesmrec jesmrec requested review from Aitorbp and JuancaG05 March 19, 2024 14:19
Copy link
Contributor

@Aitorbp Aitorbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment for you to review @jesmrec 👍

.github/workflows/calens.yml Outdated Show resolved Hide resolved
@jesmrec jesmrec force-pushed the feature/adapt_3rd_party_apps_to_conventional_commits branch from 077374a to 07a8578 Compare March 20, 2024 08:58
@jesmrec jesmrec requested a review from JuancaG05 March 20, 2024 08:59
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jesmrec jesmrec force-pushed the feature/adapt_3rd_party_apps_to_conventional_commits branch from 152c8ac to 389abf1 Compare March 20, 2024 09:51
@jesmrec jesmrec merged commit c22d2a3 into master Mar 20, 2024
3 checks passed
@jesmrec jesmrec deleted the feature/adapt_3rd_party_apps_to_conventional_commits branch March 20, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants