Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Some bugs related to Details view #4265

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Dec 18, 2023

Related Issues

App: #4188

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Checks done: #4265 (comment)

@JuancaG05 JuancaG05 self-assigned this Dec 18, 2023
@JuancaG05 JuancaG05 linked an issue Dec 18, 2023 that may be closed by this pull request
@JuancaG05 JuancaG05 changed the title Show correct toolbar when coming from image or video preview activities [BUG] Some bugs related to Details view Dec 18, 2023
@JuancaG05 JuancaG05 changed the title [BUG] Some bugs related to Details view [FIX] Some bugs related to Details view Dec 18, 2023
@JuancaG05 JuancaG05 marked this pull request as ready for review December 18, 2023 08:41
@JuancaG05 JuancaG05 requested a review from Aitorbp December 18, 2023 08:41
Copy link
Contributor

@Aitorbp Aitorbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything good for my side

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 8, 2024

Checks done:

Report (1) tested with:

  • Previewable file in root folder of personal space
  • Previewable file in non-root folder of personal space
  • Previewable file in root folder of non-personal space
  • Previewable file in non-root folder of non-personal space
  • Previewable file in root folder of oC10
  • Previewable file in non-root folder of oC10

Report (2)

  • File in root folder of personal space
  • File in non-root folder of personal space
  • File in root folder of oC10
  • File in non-root folder of oC10

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 8, 2024

(1) [FIXED]

This is a weird behaviour that i only reproduce in oCIS with images that are not in root folder

  1. Open the image
  2. Click on 3-dot-button and Details

Current: Displayed root folder, no matter the space in which the image is
Expected: Details open

NOTE:

Pixel 2 Android 11
Samsung Tab 8, Android 13
57fdf5b1f

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 9, 2024

(1) is reproducible in 4.1.1 so it could be moved to another issue (not a regression). But, that problem prevents to reproduce correctly the 2nd report in the issue.

Checking with an image in root folder, the 2nd item is fixed.

So, here we have to choose between two options:

  • Fixing here and getting rid of the problem, if feasible.
  • Move to another issue assuming that the behaviour could not no be correct for items in non-root folder (not testable with the problem)

open to discussion

@JuancaG05 JuancaG05 force-pushed the fix/navigation_details_view branch from 0edb654 to 025e740 Compare January 15, 2024 08:47
@JuancaG05
Copy link
Collaborator Author

Since it was an ugly bug, I decided to fix it here. (1) should be solved and fixes in this PR already testable 👍

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 15, 2024

(1) fixed

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 15, 2024

Approved an my side

@JuancaG05 JuancaG05 merged commit f8b733c into master Jan 16, 2024
@JuancaG05 JuancaG05 deleted the fix/navigation_details_view branch January 16, 2024 07:33
Aitorbp pushed a commit that referenced this pull request Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Some bugs related to Details view
3 participants