[FEATURE REQUEST] Auto-refresh when a file is uploaded

[JuancaG05]

Related Issues

App: #4103

• Added changelog files for the fixed issues in folder changelog/unreleased. More info here

---

QA

Checklist:

#4199 (comment)

Reports:

• (1) NEW CONTENT staying in screen when browsing [FEATURE REQUEST] Auto-refresh when a file is uploaded #4199 (comment)
• (2) NEW CONTENT in wrong folder [FEATURE REQUEST] Auto-refresh when a file is uploaded #4199 (comment)

[manuelplazaspalacio]

Some change here @JuancaG05

[manuelplazaspalacio]

LGTM!!

[jesmrec]

Manual uploads

• 1 file
• 10 files
• 100 files
• 200 files (updating New content)
• 500 files (updating New content)
• 500 files (without updating New content, checking in web)
• 1000 files (updating new content) -> performance falls a little bit
• 1000 files (without updating New content, checking in web)
• 1000 files (outside the target folder)
• 1000 files (changing tab) -> performance not so good
• Changing number of refreshes max_uploads_to_refresh
• "New content" removed if manual refresh happens
• "New content" removed if browsing back and forth
• "New content" removed if browsing to another tab

Other (regression):

• Auto uploads
• Uploads from camera
• Uploads from 3rd party

Error:

• Connection error
• Server connection error
• Maintenance mode (oC10)

[manuelplazaspalacio]

LGTM!!

[jesmrec]

(1)

1. Upload a number of files > max_uploads_to_refresh
2. When NEW CONTENT is displayed, browse to another folder without refreshing.

Current: NEW CONTENT stays in the screen
Expected: not totally sure... i'd think for the NEW CONTENT to update the content of the current folder in case new items where uploaded to that location. If i move to another location, it loses the meaning because this place is updated since it was just browsed. So, i'd go to remove the NEW CONTENT if browsing to another place

Pixel 2 Android 11
e2404875

[JuancaG05]

@jesmrec (1) should be fixed now 👍

[jesmrec]

i'd raise the default number of uploads to refresh to 200. In terms of performance is affordable and reduce the number of interactions.

[jesmrec]

(2)

1. Upload a number of files > max_uploads_to_refresh
2. Just after submitting the upload, browse to another folder, no matter which one and stay there

Current: After some time (when the number of finished uploads overtakes the limit), the fab to refresh is displayed
Expected: Never shown in that folder since this is not the folder to refresh

Pixel 2 Android 11
d7c56dd61

[JuancaG05]

@jesmrec (2) should be fixed now.
I also updated the maximum number of uploads to refresh automatically to 200, and I introduced a change that I hope helps with performance: manual refresh button will trigger a new refresh only when there is not another one in progress, otherwise it will show a snackbar informing the user there is already a synchronization in progress

[jesmrec]

This is approved on my side.

Just as clarification: for a very big amount of files, performance could be affected since device affords too many operations at the time: uploads management including statuses changes, UI updates and long PROPFINFDs parsing that triggers also DB updates. For a reasonable amount of files (1000 - 1500) at the time, this is affordable for a budget device. But, i can not assure that a much bigger amount is going to be performant, depending on the device.

Open to iterate here somehow.