Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Introduce new error message for ProtocolException #4013

Merged
merged 3 commits into from
Apr 13, 2023
Merged

[FIX] Introduce new error message for ProtocolException #4013

merged 3 commits into from
Apr 13, 2023

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Apr 11, 2023 •
edited
Loading

Related Issues

App: #3948

Library PR (if needed): owncloud/android-library#558

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@JuancaG05 JuancaG05 requested a review from abelgardep April 11, 2023 06:59
@JuancaG05 JuancaG05 self-assigned this Apr 11, 2023
@JuancaG05 JuancaG05 linked an issue Apr 11, 2023 that may be closed by this pull request
[BUG] Error handling in uploads #3948
Closed
@JuancaG05 JuancaG05 force-pushed the fix/unknown_error_message branch from c10578d to 3e9d56b Compare April 11, 2023 08:29
@abelgardep abelgardep mentioned this pull request Apr 12, 2023
Merged
abelgardep
abelgardep reviewed Apr 12, 2023
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little suggestion here @JuancaG05

owncloudApp/src/main/res/values/strings.xml Show resolved Hide resolved
@JuancaG05 JuancaG05 requested a review from abelgardep April 12, 2023 08:44
@JuancaG05 JuancaG05 force-pushed the fix/unknown_error_message branch from 3e9d56b to b8e1126 Compare April 12, 2023 08:45
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 12, 2023

Approved

@JuancaG05 JuancaG05 merged commit 4dc2411 into master Apr 13, 2023
@JuancaG05 JuancaG05 deleted the fix/unknown_error_message branch April 13, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelgardep abelgardep abelgardep approved these changes

Assignees

@JuancaG05 JuancaG05

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Error handling in uploads
3 participants
@JuancaG05 @jesmrec @abelgardep