Koin dsl #3966
Merged
Koin dsl #3966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are still interested, will not be closed. As usual, time reduced. Thanks a lot. EDIT: will ping you when conflicts must be solved to test/merge |
|
I'm not able to fix the conflicts because I don't have write access to the repository anymore 😢 I could try to cherry-pick and create a new PR from my fork though. Otherwise, you will need to fix the conflicts yourselves. So up to you 👍 |
|
We'll try to fix first. Thanks again for your engagement. |
Should be fixed 👍 |
abelgardep
force-pushed
the
koin_dsl
branch
from
b7d0df9 to
e76e228
Compare
|
Rebased. Little consideration: We can't inject over 10 dependencies using koin dsl. For example, that's why I kept |
JuancaG05
requested changes
Sep 12, 2023
owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/LocalDataSourceModule.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/dependecyinjection/LocalDataSourceModule.kt
Outdated
Show resolved
Hide resolved
|
Changes applied and rebased @JuancaG05 🍻 |
JuancaG05
approved these changes
Oct 3, 2023
Aitorbp
pushed a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Koin now offer a new kind of DSL keyword that allow you to target a class constructor directly, and avoid to to have type your definition within a lambda expression.
Use koin constructor dsl to inject view models, repositories, data sources etc.. Its a little bit cleaner now, and no need to introduce
get() get() get()over the whole module.QA