-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SPACES] Support file and folders operations with Spaces in DocumentsProvider #3941
Conversation
One open question here: "Move to other space in same account" operation is banned in the app, but available in doc provider. i guess that it's not straightforward to prevent this... but it is a shortcut to jump over the app restriction. Is this OK? |
In Android, since we use the native documents provider, we cannot restrict this behaviour. In fact, the move operation is not performed as it is, since we invoke the move usecase and an exception is thrown if we try to move to a different space. When this happens, the documents provider catches internally the exception and performs an "artificial" move, which means downloading the file from the source, upload it to the destination and deleting it from the source. This artificial move is performed as well when trying to move between accounts through the documents provider -> not allowed in the app but from the document provider. In conclusion, a remote move is not performed in server, but we cannot restrict it since it is a native and internal behaviour from Android. We'll see if this is doable in future versions of documents provider. /CC @michaelstingl |
A complete sanity test was done over the feature, including operations over oCIS accounts with spaces, oC10 accounts and other providers. Some open issues are still reproducible: These three, related with Keep in mind also this issue with improvements that point to the mentioned issues: #2336 Since those are known issues and do not affect the oCIS' spaces implementation, i do not have objections to move this forward, keeping in mind that some scenarios are not working fine. If any other idea/suggestion/solution to improve the known bad scenarios, is totally welcome. |
6373f31
to
9f25263
Compare
Related Issues
App: #3881
QA