[SPACES] Use personal as a regular space #3920

abelgardep · 2023-02-17T10:35:52Z

Implements #3919

Includes potential fix to #3923

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_4.0/Personal%20Space%20Graph%20API.md

(1) Shared folder clicked to "no shares" view [SPACES] Use personal as a regular space #3920 (comment) [FIXED]
(2) Pull to refresh si gone in shares [SPACES] Use personal as a regular space #3920 (comment) [WONT FIX HERE]
(3) Operations over shared items [SPACES] Use personal as a regular space #3920 (comment) [DONE]
(4) Glitch in navigation after downloading item in shares view][SPACES] Use personal as a regular space #3920 (comment) [FIXED]
(5) Search bar closes after typing a character [SPACES] Use personal as a regular space #3920 (comment) [FIXED]

Capabilities and spaces are mandatory to know if we need to work as a legacy account (oC10) or as a spaces account. Database and Storage hierarchy involved 👍

…CIS accounts

SharesFragment will display all the shares once #3917 is implemented

…s virtual space is not retrieved in that case

JuancaG05

Good job @abelgardep, some comments here 🎶

...udApp/src/main/java/com/owncloud/android/presentation/files/filelist/MainFileListFragment.kt

owncloudApp/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt

owncloudApp/src/main/res/layout/shares_fragment.xml

...a/com/owncloud/android/presentation/viewmodels/authentication/AuthenticationViewModelTest.kt

owncloudData/src/main/java/com/owncloud/android/data/spaces/db/SpacesEntity.kt

...ain/src/main/java/com/owncloud/android/domain/files/usecases/GetRootFolderPersonalUseCase.kt

...omain/src/main/java/com/owncloud/android/domain/files/usecases/GetRootFolderSharesUseCase.kt

JuancaG05

💯

[SPACES] Support thumbnails for spaces

jesmrec · 2023-02-23T12:20:11Z

(1) [FIXED]

User1 shares a folder with User2 in oCIS server
User2 accepts the share in web
User2 opens app and clicks on Shares tab on the bottom bar -> folder listed there ✅
User2 clicks on folder

Current: No shares view (intended? or next iteration?)
Expected: either folder is not clickable or clicking folder shows content (other options?)

Samsung A51, Android12
99c600d4c2

jesmrec · 2023-02-23T12:29:38Z

(2) [WONT FIX HERE]

User1 shares files or folders with User2 in oCIS server (no accepted shares in user2 account)
Install app from scratch
Add oCIS account (User2)
Open "Shares" tab -> empty ✅
In web, user2 accepts all pending stuff
In app, user2 refresh shares view

Current: No way to refresh, pull to refresh seems to be gone after fresh install. By switching tabs, it works
Expected: pull to refresh available the first time

Samsung A51, Android12
99c600d4c2

jesmrec · 2023-02-23T12:41:58Z

(3) [DONE]

question/discussion, maybe not to fix in this PR:

which operations to be available in shares view over the accepted shares:

Download: done and working ✅
Delete: it should be posible to remove the local copy, now it is not ❌
Copy / Move: Get a copy... i'd say yes. Move... i'd say no
Rename: no idea...
Av. offline: done and working ✅
Share: for resharing (not working -> error retrieved ❌ )

We could move this for next iterations, but please keep it in mind.

jesmrec · 2023-02-23T12:47:10Z

(4) [FIXED]

User1 shares a PDF (or any file in a non-previewable format) with User2
User2 accepts the share in web
User2 opens app and Shares tab -> file is listed there ✅
User2 clicks on PDF to download it -> download done in Details view

Current: no way to go back to list of shares. no back arrow. No reproducible in list of files
Expected: back arrow there

Samsung A51, Android12
99c600d4c2

jesmrec · 2023-02-23T13:06:36Z

(5) [FIXED]

in oCIS account

Open personal space
Click on lens icon on top bar
Type some characters to look for

Current: search bar closes after every typed character
Expected: search bar does not close

NOTE: only happens in personal space and oCIS account. Not reproducible in spaces/main

device-2023-02-23-140104.mp4

Samsung A51, Android12
99c600d4c2

abelgardep · 2023-02-23T13:54:15Z

(1) Issue is that the folder is not refreshed after opening it. So it's empty locally. If we pull to refresh, the content will be fetched and displayed. Already in spaces/main when opening folders in the Links section. Should be fixed now.
(2) Could be related to #3919 (comment) Reproducible with the latest oCIS builds (fe: ocis.owncloud.works)?
(3) We maintain the same operations that were available in Links section on 3.0.3. We could delete the files from Details/Preview as a workaround. About the resharing error, I need to check it but I would move it to a different issue
(4) and (5) I'll check them 👍

… in search filters or files content

jesmrec · 2023-02-27T08:04:44Z

(1) -> fixed
(2) -> will be fixed when sharing feature is complete.
(3) -> moved to #3937. Removing from Details ftm.
(4) -> fixed
(5) -> fixed

jesmrec · 2023-02-27T11:12:28Z

#3923 fixed too

… updated

jesmrec · 2023-02-28T07:56:46Z

Ready to go!!

abelgardep self-assigned this Feb 17, 2023

abelgardep added 3 commits February 20, 2023 08:00

First draft of account discovery

51bf38e

Capabilities and Spaces retrieval as part of the login flow

dd6bebb

Capabilities and spaces are mandatory to know if we need to work as a legacy account (oC10) or as a spaces account. Database and Storage hierarchy involved 👍

Reposition shares in the bottom navigation bar and use new icon for o…

c290e52

…CIS accounts

abelgardep force-pushed the spaces/account_discovery branch from ab39611 to c290e52 Compare February 20, 2023 07:03

abelgardep added 7 commits February 20, 2023 09:09

Adapt tests to new behavior

f9ac09c

Remove duplicated key, already in OCFile class

f522985

Use the personal space when receiving files from external apps

69a06ee

Remove unused imports

306f8a8

Adapt tests to new behavior

92f1eff

Introduce SharesFragment and fix navigation temporary

1cb073c

SharesFragment will display all the shares once #3917 is implemented

Fix navigation to Shares when there are no accepted shares yet. Share…

a0dcfce

…s virtual space is not retrieved in that case

abelgardep linked an issue Feb 21, 2023 that may be closed by this pull request

[SPACES] Use personal as a regular space #3919

Closed

9 tasks

abelgardep mentioned this pull request Feb 21, 2023

[SPACES] Use personal as a regular space #3919

Closed

9 tasks

abelgardep marked this pull request as ready for review February 21, 2023 17:11

abelgardep requested a review from JuancaG05 February 21, 2023 17:11

Show empty shares when shares space is empty

09161a6

jesmrec mentioned this pull request Feb 22, 2023

[SPACES] Copy and move operations #3863

Closed

21 tasks

Support thumbnails for spaces

a337e9d

JuancaG05 requested changes Feb 22, 2023

View reviewed changes

Apply CR suggestions

a39093e

abelgardep requested a review from JuancaG05 February 22, 2023 16:30

JuancaG05 approved these changes Feb 22, 2023

View reviewed changes

abelgardep and others added 6 commits February 23, 2023 10:03

Merge pull request #3929 from owncloud/spaces/thumbnails

2ea719a

[SPACES] Support thumbnails for spaces

Show correct items in toolbar and bottom bar when copying or moving

b22184d

Only showing list of spaces for copy action when it is a oCIS account

58a4920

Copying into same folder is now possible within the same space

6a80c14

Handle error 409 with new message

33acbfb

Checking if we are in oCIS depending on spaceId value

99c60d4

jesmrec mentioned this pull request Feb 23, 2023

[BUG] Bottom bar navigation not correct #3923

Closed

Refresh folder when browsing in av offlines and shares/links

3a054b0

jesmrec mentioned this pull request Feb 24, 2023

[SPACES] Hide "Share" option out of Personal space #3937

Closed

Update toolbar only when the folder displayed changes, not any change…

5ecf394

… in search filters or files content

abelgardep force-pushed the spaces/account_discovery branch from d4f64ee to 5ecf394 Compare February 24, 2023 14:02

Update toolbar when space is fetched, otherwise sometimes it won't be…

663c324

… updated

jesmrec added the Approved by qa label Feb 28, 2023

abelgardep added this pull request to the merge queue Feb 28, 2023

Merged via the queue into spaces/main with commit 0116c8a Feb 28, 2023

abelgardep deleted the spaces/account_discovery branch February 28, 2023 07:58

abelgardep mentioned this pull request Feb 28, 2023

[SPACES] Main features #3851

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SPACES] Use personal as a regular space #3920

[SPACES] Use personal as a regular space #3920

abelgardep commented Feb 17, 2023 •

edited by jesmrec

Loading

JuancaG05 left a comment

JuancaG05 left a comment

jesmrec commented Feb 23, 2023 •

edited

Loading

jesmrec commented Feb 23, 2023 •

edited

Loading

jesmrec commented Feb 23, 2023 •

edited

Loading

jesmrec commented Feb 23, 2023 •

edited

Loading

jesmrec commented Feb 23, 2023 •

edited

Loading

abelgardep commented Feb 23, 2023 •

edited

Loading

jesmrec commented Feb 27, 2023

jesmrec commented Feb 27, 2023

jesmrec commented Feb 28, 2023

[SPACES] Use personal as a regular space #3920

[SPACES] Use personal as a regular space #3920

Conversation

abelgardep commented Feb 17, 2023 • edited by jesmrec Loading

QA

JuancaG05 left a comment

Choose a reason for hiding this comment

JuancaG05 left a comment

Choose a reason for hiding this comment

jesmrec commented Feb 23, 2023 • edited Loading

(1) [FIXED]

jesmrec commented Feb 23, 2023 • edited Loading

(2) [WONT FIX HERE]

jesmrec commented Feb 23, 2023 • edited Loading

(3) [DONE]

jesmrec commented Feb 23, 2023 • edited Loading

(4) [FIXED]

jesmrec commented Feb 23, 2023 • edited Loading

(5) [FIXED]

abelgardep commented Feb 23, 2023 • edited Loading

jesmrec commented Feb 27, 2023

jesmrec commented Feb 27, 2023

jesmrec commented Feb 28, 2023

abelgardep commented Feb 17, 2023 •

edited by jesmrec

Loading

jesmrec commented Feb 23, 2023 •

edited

Loading

jesmrec commented Feb 23, 2023 •

edited

Loading

jesmrec commented Feb 23, 2023 •

edited

Loading

jesmrec commented Feb 23, 2023 •

edited

Loading

jesmrec commented Feb 23, 2023 •

edited

Loading

abelgardep commented Feb 23, 2023 •

edited

Loading