Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPACES] Spaces available only for fresh accounts #3914

Merged
merged 2 commits into from
Feb 16, 2023
Merged

[SPACES] Spaces available only for fresh accounts #3914

merged 2 commits into from
Feb 16, 2023

Conversation

abelgardep
Copy link
Contributor

Related Issues

Implements #3906

Library PR (if needed):

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@abelgardep abelgardep self-assigned this Feb 14, 2023
@abelgardep abelgardep linked an issue Feb 14, 2023 that may be closed by this pull request
[SPACES] oCIS account detection #3906
Closed
9 tasks
@abelgardep abelgardep changed the title [Spaces] Spaces available only for fresh accounts [SPACES] Spaces available only for fresh accounts Feb 14, 2023
@abelgardep abelgardep marked this pull request as ready for review February 15, 2023 06:43
@abelgardep abelgardep requested a review from JuancaG05 February 15, 2023 06:43
JuancaG05
JuancaG05 requested changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments here 👍 Good job!

owncloudApp/src/main/java/com/owncloud/android/presentation/authentication/AccountUtils.java Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/activity/DrawerActivity.kt Outdated Show resolved Hide resolved
@abelgardep abelgardep requested a review from JuancaG05 February 15, 2023 10:36
JuancaG05
JuancaG05 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to QA @jesmrec 🚀

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 15, 2023

AFAICS, nothing to test here. Just a new flag and logic to manage it. It will be tested together with the UI notifications for users to re-attach legacy accounts. CI is green, OK from my side unless you point me to test something else here.

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 16, 2023

QA

  • Add oCIS and oC10 accounts after fresh install -> oCIS accounts shows spaces, oC10 accounts do not show spaces

With oCIS and oC10 account in the device in master:

  • Update from master -> oCIS accounts do not show spaces, oC10 accounts do not show spaces
  • Add account after updating -> oCIS accounts show spaces, oC10 accounts do not show spaces

Approved on my side

@abelgardep abelgardep added this pull request to the merge queue Feb 16, 2023
Merged via the queue into spaces/main with commit 7d65ece Feb 16, 2023
@abelgardep abelgardep deleted the spaces/specific_version_features branch February 16, 2023 08:23
@JuancaG05 JuancaG05 mentioned this pull request Feb 16, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@abelgardep abelgardep

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SPACES] oCIS account detection
3 participants
@abelgardep @jesmrec @JuancaG05