Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPACES] Local Storage #3891

Merged
merged 3 commits into from
Feb 9, 2023
Merged

[SPACES] Local Storage #3891

merged 3 commits into from
Feb 9, 2023

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Feb 2, 2023 •
edited by JuancaG05
Loading

Related Issues

Implements #3808

Library PR (if needed): owncloud/android-library#537

QA

@abelgardep
Support downloads from specific spaces
59f0cbe 
Spaces will have their own hierarchy under the spaceId of each space
@abelgardep abelgardep self-assigned this Feb 2, 2023
@abelgardep abelgardep mentioned this pull request Feb 2, 2023
Merged
@abelgardep
Copy link
Contributor Author

Applied the 1st option from #3808 (comment)

Take into account that this is how fresh installments / new accounts will work. For old oCIS accounts, the storage will remain the same. (Will be done on a different issue, pending to be created). No migration from an old oCIS account to spaces. The user will need to remove the account and add it again to get the space features.

Ready to test

  • Any type of download (Av offline, downloads, Documents provider)
  • Send and Open with should work now with spaces. (If not downloaded, the file is enqueued, downloaded, and the share sheet is shown)
  • Already supported operations on spaces (rename, remove, remove local only, etc)

@abelgardep abelgardep requested a review from JuancaG05 February 8, 2023 16:54
@abelgardep abelgardep marked this pull request as ready for review February 8, 2023 16:54
@abelgardep abelgardep linked an issue Feb 8, 2023 that may be closed by this pull request
[SPACES] Adapt Scoped Storage to Space's folder structure. Check Download action #3808
Closed
11 tasks
@abelgardep abelgardep mentioned this pull request Feb 8, 2023
Closed
11 tasks
JuancaG05
JuancaG05 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just a tiny comment, but from my point of view, ready to go 🚀

owncloudData/src/main/java/com/owncloud/android/data/storage/LocalStorageProvider.kt Show resolved Hide resolved
@JuancaG05 JuancaG05 merged commit ecf0e6e into spaces/main Feb 9, 2023
@JuancaG05 JuancaG05 deleted the spaces/storage branch February 9, 2023 09:09
@JuancaG05 JuancaG05 changed the title [Spaces] Local Storage [SPACES] Local Storage Feb 9, 2023
@JuancaG05 JuancaG05 mentioned this pull request Feb 9, 2023
Merged
1 task
@jesmrec
Copy link
Collaborator

jesmrec commented Feb 9, 2023

Approved from my side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@abelgardep abelgardep

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SPACES] Adapt Scoped Storage to Space's folder structure. Check Download action
3 participants
@abelgardep @jesmrec @JuancaG05