Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPACES] Document Provider showing available Spaces #3875

Merged
merged 8 commits into from
Feb 2, 2023
Merged

[SPACES] Document Provider showing available Spaces #3875

merged 8 commits into from
Feb 2, 2023

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Jan 26, 2023 •
edited by jesmrec
Loading

@JuancaG05 JuancaG05 requested a review from abelgardep January 26, 2023 12:58
@JuancaG05 JuancaG05 self-assigned this Jan 26, 2023
@JuancaG05 JuancaG05 changed the title Spaces/document provider [SPACES] Document Provider showing available Spaces Jan 26, 2023
@JuancaG05 JuancaG05 linked an issue Jan 26, 2023 that may be closed by this pull request
[SPACES] Document Provider showing available Spaces #3809
Closed
12 tasks
@JuancaG05 JuancaG05 force-pushed the spaces/document_provider branch from 5d5e711 to c0dae4f Compare January 30, 2023 07:43
@JuancaG05 JuancaG05 marked this pull request as ready for review January 30, 2023 12:35
abelgardep
abelgardep suggested changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions here @JuancaG05

.../java/com/owncloud/android/data/spaces/datasources/implementation/OCLocalSpacesDataSource.kt Outdated Show resolved Hide resolved
...App/src/main/java/com/owncloud/android/presentation/documentsprovider/cursors/SpaceCursor.kt Outdated Show resolved Hide resolved
...App/src/main/java/com/owncloud/android/presentation/documentsprovider/cursors/SpaceCursor.kt Outdated Show resolved Hide resolved
...App/src/main/java/com/owncloud/android/presentation/documentsprovider/cursors/SpaceCursor.kt Outdated Show resolved Hide resolved
.../java/com/owncloud/android/data/spaces/datasources/implementation/OCLocalSpacesDataSource.kt Outdated Show resolved Hide resolved
@JuancaG05 JuancaG05 requested a review from abelgardep January 31, 2023 09:23
abelgardep
abelgardep approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Ready to QA @jesmrec

@JuancaG05 JuancaG05 force-pushed the spaces/document_provider branch from f4914f1 to 6b54988 Compare January 31, 2023 15:13
@jesmrec
Copy link
Collaborator

jesmrec commented Jan 31, 2023

Let's QA this

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 31, 2023 •
edited
Loading

(1) [FIXED]

  1. Add two oCIS accounts with spaces to the app
  2. Open any app with document provider access and open one of the oC accounts -> spaces listed ✅
  3. In document provider app, switch to the other account

Current: listed spaces from the first account (step 2)
Expected: listed spaces from the second account (step 3)

Samsung A51, Android 12
6b549881d

Base automatically changed from spaces/list_content to spaces/main January 31, 2023 17:20
@abelgardep abelgardep force-pushed the spaces/document_provider branch from 6b54988 to 4317625 Compare January 31, 2023 17:28
@jesmrec
Copy link
Collaborator

jesmrec commented Feb 2, 2023

Approved on my side

Enhancement: #3888

@abelgardep abelgardep merged commit f24a4c5 into spaces/main Feb 2, 2023
@abelgardep abelgardep deleted the spaces/document_provider branch February 2, 2023 09:59
@JuancaG05 JuancaG05 mentioned this pull request Feb 9, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelgardep abelgardep abelgardep approved these changes

Assignees

@JuancaG05 JuancaG05

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SPACES] Document Provider showing available Spaces
3 participants
@JuancaG05 @jesmrec @abelgardep