Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPACES] Increase spaces thumbnails to support different screen sizes #3855

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

abelgardep
Copy link
Contributor

The thumbnails were a little bit too small for some resolutions. Now, they should escalate a little bit

QA

@abelgardep abelgardep self-assigned this Jan 12, 2023
@JuancaG05 JuancaG05 self-requested a review January 12, 2023 13:54
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks better now! 👍

@abelgardep abelgardep changed the title Increase spaces thumbnails to support different screen sizes [SPACES] Increase spaces thumbnails to support different screen sizes Jan 13, 2023
@jesmrec
Copy link
Collaborator

jesmrec commented Jan 13, 2023

Checked in tablet emulator, with and without spaces, and using both orientations. This look matches better to the tablet users. It's OK from my side.

@abelgardep abelgardep merged commit 3aa2dfd into spaces/main Jan 13, 2023
@abelgardep abelgardep deleted the spaces/tablet_support branch January 13, 2023 12:06
@abelgardep abelgardep mentioned this pull request Jan 13, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants