Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPACES] Create new "Spaces" view #3843

Merged
merged 20 commits into from
Jan 11, 2023
Merged

[SPACES] Create new "Spaces" view #3843

merged 20 commits into from
Jan 11, 2023

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Dec 21, 2022 •
edited by jesmrec
Loading

Related Issues

App: #3805

Library PR (if needed): owncloud/android-library#527

QA

@abelgardep abelgardep self-assigned this Dec 21, 2022
@abelgardep abelgardep linked an issue Dec 21, 2022 that may be closed by this pull request
[SPACES] Create new "Spaces" view #3805
Closed
18 tasks
@abelgardep abelgardep mentioned this pull request Dec 21, 2022
Closed
18 tasks
@abelgardep abelgardep changed the base branch from master to spaces/tab_in_bottom_bar December 23, 2022 20:06
@JuancaG05 JuancaG05 mentioned this pull request Dec 27, 2022
Merged
@JuancaG05 JuancaG05 changed the title [SPACES] Fetch spaces [SPACES] Create new "Spaces" view Dec 27, 2022
@JuancaG05 JuancaG05 self-assigned this Dec 27, 2022
@JuancaG05 JuancaG05 force-pushed the spaces/fetch_spaces branch 2 times, most recently from 5cbcb7d to ed5fd0d Compare December 29, 2022 08:50
Base automatically changed from spaces/tab_in_bottom_bar to spaces/main January 10, 2023 08:29
@JuancaG05 JuancaG05 marked this pull request as ready for review January 11, 2023 09:40
@JuancaG05 JuancaG05 self-requested a review January 11, 2023 09:43
@JuancaG05 JuancaG05 force-pushed the spaces/fetch_spaces branch from 024ae8f to a554b10 Compare January 11, 2023 11:28
@JuancaG05 JuancaG05 force-pushed the spaces/fetch_spaces branch from a554b10 to 2edfe5d Compare January 11, 2023 11:35
@jesmrec
Copy link
Collaborator

jesmrec commented Jan 11, 2023

(1)

Steps:

  1. In web, create space with image
  2. Open app > Spaces. Space with the image correctly shown
  3. In web, edit image, setting a new one for the space
  4. In app, pull to refresh in Spaces view

Current: image not refreshed. Required to browse through tabs to get an update
Expected: Pull to refresh, refreshing image as the title and subtitle do

Samsung A51, Android12
bb0260d3

@JuancaG05 JuancaG05 merged commit 65b5050 into spaces/main Jan 11, 2023
@JuancaG05 JuancaG05 deleted the spaces/fetch_spaces branch January 11, 2023 12:51
@JuancaG05 JuancaG05 mentioned this pull request Jan 13, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@abelgardep abelgardep

@JuancaG05 JuancaG05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SPACES] Create new "Spaces" view
3 participants
@abelgardep @jesmrec @JuancaG05