Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Arch] Allow local removal when device is not connected #3727

Merged
merged 1 commit into from
Aug 18, 2022
Merged

[New Arch] Allow local removal when device is not connected #3727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...ain/java/com/owncloud/android/presentation/ui/files/operations/FileOperationsViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ class FileOperationsViewModel(
liveData = _removeFileLiveData,
useCase = removeFileUseCase,
useCaseParams = RemoveFileUseCase.Params(fileOperation.listOfFilesToRemove, fileOperation.removeOnlyLocalCopy),
postValue = fileOperation.listOfFilesToRemove
postValue = fileOperation.listOfFilesToRemove,
requiresConnection = !fileOperation.removeOnlyLocalCopy,
)
}

Expand Down Expand Up @@ -158,12 +159,13 @@ class FileOperationsViewModel(
liveData: MediatorLiveData<Event<UIResult<PostResult>>>,
useCase: BaseUseCaseWithResult<Type, Params>,
useCaseParams: Params,
postValue: PostResult? = null
postValue: PostResult? = null,
requiresConnection: Boolean = true,
) {
viewModelScope.launch(coroutinesDispatcherProvider.io) {
liveData.postValue(Event(UIResult.Loading()))

if (!contextProvider.isConnected()) {
if (!contextProvider.isConnected() && requiresConnection) {
liveData.postValue(Event(UIResult.Error(error = NoNetworkConnectionException())))
Timber.w("${useCase.javaClass.simpleName} will not be executed due to lack of network connection")
return@launch
Expand Down