Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when opening a non downloaded file from Details view #3696

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Fix crash when opening a non downloaded file from Details view #3696

merged 3 commits into from
Jun 13, 2022

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Jun 13, 2022 •
edited
Loading

Fix a crash when opening a file that was not downloaded from the details view

Steps to reproduce:

  1. Select a file
  2. Open the details view without downloading it
  3. Select open with

Stacktrace:

java.lang.NullPointerException: 
  at com.owncloud.android.ui.helpers.FileOperationsHelper.getIntentForGuessedMimeType (FileOperationsHelper.java:78)
  at com.owncloud.android.ui.helpers.FileOperationsHelper.openFile (FileOperationsHelper.java:94)
  at com.owncloud.android.ui.fragment.FileDetailFragment.onOptionsItemSelected (FileDetailFragment.java:284)
  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@abelgardep abelgardep requested a review from JuancaG05 June 13, 2022 08:33
@abelgardep abelgardep self-assigned this Jun 13, 2022
JuancaG05
JuancaG05 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec jesmrec added this to the 2.21-current milestone Jun 13, 2022
@jesmrec
Copy link
Collaborator

jesmrec commented Jun 13, 2022

Thanks a lot for reporting and fixing.

Please go on.

@abelgardep abelgardep force-pushed the fix/crash_details_open branch from dbec3bb to 3382b0a Compare June 13, 2022 10:08
@abelgardep abelgardep merged commit 3199a17 into master Jun 13, 2022
@abelgardep abelgardep deleted the fix/crash_details_open branch June 13, 2022 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

Assignees

@abelgardep abelgardep

Labels
Approved by qa Estimation - 2 (S)
Projects
None yet
Milestone
2.21-current
Development

Successfully merging this pull request may close these issues.
3 participants
@abelgardep @jesmrec @JuancaG05