share a folder from inside the folder

[davcres]

Related Issues

App: #1441

• Added changelog files for the fixed issues in folder changelog/unreleased. More info here

---

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.21/3659-Share%20folder%20from%20inside.md

• (1) Share with shows the share icon share a folder from inside the folder #3659 (comment) [FIXED]
• (2) Operations that show the share icon in the folder picker share a folder from inside the folder #3659 (comment) [FIXED]

[fesave]

LGTM

[jesmrec]

(1) [FIXED]

1. Open an external app (Gallery, Photos...)
2. Select a file and share with oC

Current: folder picker shows the share icon on the top bar. By clicking, nothing happens
Expected: folder picker should not show the share icon on the top bar

Pixel 5 v12
611970ac

[jesmrec]

(2) [FIXED]

Following (1), the share icon also is displayed when:

• Select a path in the Auto uploads
• Select a target folder in the copy/move actions

In both cases, the share operation works fine and the folder is correctly shared.

The question here... should we keep it? such operations do not have nothing to do with sharing.

My personal opinion: Remove the icon from there.

[davcres]

(2)

Following (1), the share icon also is displayed when:

• Select a path in the Auto uploads
• Select a target folder in the copy/move actions

In both cases, the share operation works fine and the folder is correctly shared.

The question here... should we keep it? such operations do not have nothing to do with sharing.

My personal opinion: Remove the icon from there.

Done

[davcres]

Done

[jesmrec]

Everything fixed

approved