Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview available when user clicks on thumbnail in file detail #3653

Merged
merged 4 commits into from
May 4, 2022

Conversation

fesave
Copy link
Contributor

@fesave fesave commented May 3, 2022

When a user clicks on a file's detail view thumbnail, the file is automatically downloaded and previewed.

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

QA checks: #3653 (comment)

Reports:

@fesave fesave marked this pull request as ready for review May 3, 2022 08:16
@fesave fesave self-assigned this May 3, 2022
@fesave fesave added this to the 2.21-current milestone May 3, 2022
@fesave fesave requested review from abelgardep and davcres May 3, 2022 08:17
@jesmrec
Copy link
Collaborator

jesmrec commented May 4, 2022

QA checks

Non-downloaded

  • Image
  • PDF
  • Txt
  • Video
  • Audio
  • Office

Downloaded

  • Image
  • PDF
  • Txt
  • Video
  • Audio
  • Office

Nexus 6P, Android7
Pixel5, Android12

@jesmrec
Copy link
Collaborator

jesmrec commented May 4, 2022

(1) [FIXED]

this is related with the videos.

  1. Click on non-downloaded video and select Details
  2. Click on thumbnail -> video is downloaded and played
  3. Go back to Details
  4. Click again on thumbnail (file is already downloaded)

Current:

video is not played. share sheet is displayed instead

Expected:

videos are played into the app

Nexus6P Android7
Pixel5 Android 12
cf9a372a

@fesave
Copy link
Contributor Author

fesave commented May 4, 2022

(1)

this is related with the videos.

  1. Click on non-downloaded video and select Details
  2. Click on thumbnail -> video is downloaded and played
  3. Go back to Details
  4. Click again on thumbnail (file is already downloaded)

Current:

video is not played. share sheet is displayed instead

Expected:

videos are played into the app

Nexus6P Android7 Pixel5 Android 12 cf9a372a

Fixed :)

@fesave fesave force-pushed the feature/thumbnail_click_action branch from 1bfb4e3 to 3c95e01 Compare May 4, 2022 08:46
@jesmrec
Copy link
Collaborator

jesmrec commented May 4, 2022

(1) is fixed and the feature, approved.

Thanks!

@fesave fesave merged commit 0393764 into master May 4, 2022
@fesave fesave deleted the feature/thumbnail_click_action branch May 4, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants