Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrupt picture error controlled #3644

Merged
merged 4 commits into from
May 5, 2022
Merged

Corrupt picture error controlled #3644

merged 4 commits into from
May 5, 2022

Conversation

fesave
Copy link
Contributor

@fesave fesave commented Apr 27, 2022 •
edited
Loading

Related Issues

App: #3441

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@fesave fesave self-assigned this Apr 27, 2022
@fesave fesave linked an issue Apr 27, 2022 that may be closed by this pull request
Damaged file preview #3441
Closed
@fesave fesave requested review from abelgardep and davcres April 27, 2022 15:43
@fesave fesave marked this pull request as ready for review April 27, 2022 15:43
abelgardep
abelgardep suggested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions here @fesave

owncloudApp/src/main/res/layout/preview_image_fragment.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/preview_image_fragment.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/preview_image_fragment.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/preview_image_fragment.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/layout/preview_image_fragment.xml Outdated Show resolved Hide resolved
@fesave fesave force-pushed the fix/corrupt_picture branch from d4a07d5 to c9ec1c2 Compare April 29, 2022 07:46
@fesave fesave requested a review from abelgardep April 29, 2022 07:55
abelgardep
abelgardep approved these changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First step 👍 LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented May 4, 2022

Approved

@fesave fesave closed this May 5, 2022
@fesave fesave reopened this May 5, 2022
@abelgardep abelgardep force-pushed the fix/corrupt_picture branch from 72db2e3 to 5fda81b Compare May 5, 2022 07:30
@abelgardep abelgardep merged commit 43466a4 into master May 5, 2022
@abelgardep abelgardep deleted the fix/corrupt_picture branch May 5, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelgardep abelgardep abelgardep approved these changes

@davcres davcres Awaiting requested review from davcres

Assignees

@fesave fesave

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Damaged file preview
3 participants
@fesave @jesmrec @abelgardep