Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previewing SVG files works #3639

Merged
merged 4 commits into from
May 5, 2022
Merged

Previewing SVG files works #3639

merged 4 commits into from
May 5, 2022

Conversation

fesave
Copy link
Contributor

@fesave fesave commented Apr 27, 2022 •
edited
Loading

Related Issues

App: #1033

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@fesave fesave self-assigned this Apr 27, 2022
@fesave fesave marked this pull request as ready for review April 27, 2022 08:34
@fesave fesave requested review from abelgardep and davcres April 27, 2022 08:35
@fesave fesave linked an issue Apr 27, 2022 that may be closed by this pull request
SVG files can not be viewed #1033
Closed
abelgardep
abelgardep suggested changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions here @fesave

owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.kt Outdated Show resolved Hide resolved
owncloudApp/build.gradle Show resolved Hide resolved
owncloudApp/build.gradle Show resolved Hide resolved
@fesave fesave force-pushed the feature/preview_svg branch from 77b5492 to 0cf0697 Compare April 28, 2022 06:43
@fesave fesave requested a review from abelgardep April 28, 2022 06:50
@fesave fesave force-pushed the feature/preview_svg branch from 2c5956f to 2f7e5fd Compare April 28, 2022 07:22
@jesmrec
Copy link
Collaborator

jesmrec commented May 4, 2022

SVG preview works fine. Approved

@fesave fesave force-pushed the feature/preview_svg branch 2 times, most recently from d7d1647 to a0a5114 Compare May 5, 2022 11:39
@fesave fesave force-pushed the feature/preview_svg branch from a0a5114 to 49ed79b Compare May 5, 2022 11:41
@abelgardep abelgardep merged commit c99c947 into master May 5, 2022
@abelgardep abelgardep deleted the feature/preview_svg branch May 5, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelgardep abelgardep abelgardep approved these changes

@davcres davcres Awaiting requested review from davcres

Assignees

@fesave fesave

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVG files can not be viewed
3 participants
@fesave @jesmrec @abelgardep