Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add a new option to Settings to show What's new? #3616

Merged
merged 4 commits into from
Apr 13, 2022
Merged

[FEATURE] Add a new option to Settings to show What's new? #3616

merged 4 commits into from
Apr 13, 2022

Conversation

davcres
Copy link
Contributor

@davcres davcres commented Apr 8, 2022

Related Issues

App: #3352

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@davcres davcres requested review from abelgardep and fesave April 8, 2022 11:14
@davcres davcres linked an issue Apr 8, 2022 that may be closed by this pull request
[FEATURE REQUEST] Add a new option to Settings to show What's new? #3352
Closed
9 tasks
@abelgardep abelgardep changed the base branch from master to feature/release_notes April 11, 2022 06:57
fesave
fesave approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davcres davcres changed the title [FEATUR] Add a new option to Settings to show What's new? [FEATURE] Add a new option to Settings to show What's new? Apr 12, 2022
@davcres davcres force-pushed the feature/release_notes branch from ddc686c to 3a03089 Compare April 12, 2022 12:07
@jesmrec
Copy link
Collaborator

jesmrec commented Apr 12, 2022

QA checks:

  • release_notes_enabled = true + Notes -> upgrade shows What's new in the latest version? in Settings
  • release_notes_enabled = true + No Notes -> upgrade does not show What's new in the latest version? in Settings
  • release_notes_enabled = false + Notes -> upgrade does not show What's new in the latest version? in Settings
  • release_notes_enabled = false + No Notes -> upgrade does not show What's new in the latest version? in Settings

@jesmrec
Copy link
Collaborator

jesmrec commented Apr 12, 2022

Also approved. There are many conflicts, let me know if after resolution a new QA round is needed

@davcres davcres force-pushed the feature/settings_whatsnew branch from 49c313c to fc36ea9 Compare April 13, 2022 07:52
@davcres davcres force-pushed the feature/settings_whatsnew branch from 50dd981 to 04a1a01 Compare April 13, 2022 07:57
@jesmrec jesmrec merged commit 38df5c5 into feature/release_notes Apr 13, 2022
@jesmrec jesmrec deleted the feature/settings_whatsnew branch April 13, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fesave fesave fesave approved these changes

@abelgardep abelgardep Awaiting requested review from abelgardep

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add a new option to Settings to show What's new?
3 participants
@davcres @jesmrec @fesave