Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Lock displays shown again #3592

Merged
merged 3 commits into from
Apr 4, 2022
Merged

[Bugfix] Lock displays shown again #3592

merged 3 commits into from
Apr 4, 2022

Conversation

davcres
Copy link
Contributor

@davcres davcres commented Mar 29, 2022 •
edited by fesave
Loading

Related Issues

App: #3591

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@davcres davcres requested review from abelgardep and fesave March 29, 2022 07:54
@davcres davcres self-assigned this Mar 29, 2022
@davcres davcres linked an issue Mar 29, 2022 that may be closed by this pull request
[BUG] Passcode and Pattern activities shown again #3591
Closed
@davcres davcres changed the title fix lock display shown again [Bugfix] Lock displays shown again Mar 29, 2022
@davcres davcres force-pushed the fix/lock_activities_shown_again branch from f88dde7 to 9f90e7a Compare March 29, 2022 08:55
fesave
fesave approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Mar 30, 2022

QA checks:

  • Disable passcode + cancel
  • Disable pattern + cancel

Quick fix, approved

@davcres davcres force-pushed the fix/lock_activities_shown_again branch from 024672f to c877e34 Compare April 1, 2022 11:01
@fesave fesave merged commit 4335c0a into master Apr 4, 2022
@fesave fesave deleted the fix/lock_activities_shown_again branch April 4, 2022 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fesave fesave fesave approved these changes

@abelgardep abelgardep Awaiting requested review from abelgardep

Assignees

@davcres davcres

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Passcode and Pattern activities shown again
3 participants
@davcres @jesmrec @fesave