Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Security flags for screen recording #3560

Merged
merged 3 commits into from
Feb 24, 2022
Merged

[FIX] Security flags for screen recording #3560

merged 3 commits into from
Feb 24, 2022

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Feb 18, 2022 •
edited
Loading

Related Issues

App: #3468

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.20/3560-security_flags.md

Reports:

@JuancaG05 JuancaG05 self-assigned this Feb 18, 2022
@JuancaG05 JuancaG05 linked an issue Feb 18, 2022 that may be closed by this pull request
[BUG] Security flags for screen recording #3468
Closed
abelgardep
abelgardep approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 22, 2022

(1)

  1. Install debug variant
  2. Enable passcode/pattern
  3. Enable biometrical
  4. Quit the app and enter again

Current: biometrical asked with black screen in screen mirror (vysor used)
Expected: biometrical is mirrored as well as passcode and pattern

Pixel 2 Android11
f9b173c8

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 23, 2022

Regarding (1), i've checked with more devices and the only one in which this is reproducible is the Pixel2. Nexus6P or Huawei don't reproduce the problem either.

So, maybe something related with that device itself...

@JuancaG05
Copy link
Collaborator Author

Regarding (1), i've checked with more devices and the only one in which this is reproducible is the Pixel2. Nexus6P or Huawei don't reproduce the problem either.

So, maybe something related with that device itself...

I also checked with Samsung Galaxy S9 (Android 9) and it is not reproducible 🤔

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 23, 2022

Ok, we can assume that the report is something specific of one device. Let's move forward this then

@JuancaG05 JuancaG05 force-pushed the fix/security_screen_recording branch from f9b173c to 8d010a3 Compare February 23, 2022 11:49
@fesave fesave force-pushed the fix/security_screen_recording branch from 473d3c3 to 5f3a619 Compare February 23, 2022 17:13
fesave
fesave approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abelgardep abelgardep merged commit 9021496 into master Feb 24, 2022
@abelgardep abelgardep deleted the fix/security_screen_recording branch February 24, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fesave fesave fesave approved these changes

@abelgardep abelgardep abelgardep approved these changes

Assignees

@JuancaG05 JuancaG05

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Security flags for screen recording
4 participants
@JuancaG05 @jesmrec @abelgardep @fesave