-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable biometrical login by default after setting the passcode #3539
Conversation
17d6de9
to
062be93
Compare
5f235b7
to
24c0567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @fesave! Some comments and changes requested here
owncloudApp/src/androidTest/java/com/owncloud/android/settings/security/PassCodeActivityTest.kt
Show resolved
Hide resolved
owncloudApp/src/androidTest/java/com/owncloud/android/settings/security/PassCodeActivityTest.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/androidTest/java/com/owncloud/android/settings/security/PassCodeActivityTest.kt
Outdated
Show resolved
Hide resolved
...App/src/main/java/com/owncloud/android/presentation/viewmodels/security/PassCodeViewModel.kt
Outdated
Show resolved
Hide resolved
...dApp/src/main/java/com/owncloud/android/presentation/viewmodels/security/PatternViewModel.kt
Outdated
Show resolved
Hide resolved
...dApp/src/main/java/com/owncloud/android/presentation/viewmodels/security/PatternViewModel.kt
Outdated
Show resolved
Hide resolved
.../src/test/java/com/owncloud/android/presentation/viewmodels/security/PatternViewModelTest.kt
Outdated
Show resolved
Hide resolved
ed33a68
to
8631c47
Compare
ffa962c
to
14cf96e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tiny things here @fesave
.../src/androidTest/java/com/owncloud/android/settings/security/SettingsSecurityFragmentTest.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @fesave! 👍
995d2b9
to
90af453
Compare
Related Issues
App: https://github.com/owncloud/enterprise/issues/4977
QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.20/3539-enable_biometrical_after_passcode.md