[FEATURE REQUEST] Make document provider visibility independent from locking methods

[JuancaG05]

Related Issues

App: #3520

• Added changelog files for the fixed issues in folder changelog/unreleased. More info here

---

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.20/3538-document_provider_visibility.md

• (1) Remove dialog [FEATURE REQUEST] Make document provider visibility independent from locking methods #3538 (comment) [FIXED]
• (2) owncloud listed in doc. prov when no accounts are there [FEATURE REQUEST] Make document provider visibility independent from locking methods #3538 (comment)
• (3) Update changelog [FEATURE REQUEST] Make document provider visibility independent from locking methods #3538 (comment) [FIXED]

[abelgardep]

Just a question related to UX, but the code looks good! Good job @JuancaG05

[abelgardep]

I don't know if this is the expected behavior 🤔

Not sure if we should show a dialog to the user when he wants to enable the documents provider(which is the expected behavior) from a UX point of view

[jesmrec]

IMHO, the dialog does not make sense here since access to document provider is open by default. Warning users when the Lock option is switched off would be the same as warning when the Security section is opened. I'd remove the dialog because the feature meaning is opposite as the previous one.

[JuancaG05]

Ok, I will remove it then. Thank you!

[jesmrec]

(1) [DONE]

this one: #3538 (comment)

[jesmrec]

(2)

I noticed a tiny difference with the old behaviour

1. Install app
2. Go to Settings without adding an account)
3. Enable Lock access from document provider
4. Open any app that implements document provider

Current: owncloud is shown as Locked

Expected (before): owncloud is hidden because no accounts were attached yet

Good to fix, but not a blocker

Pixel2 V11
08b6cf94

[jesmrec]

(3) [FIXED]

Please, don't forget removing the following entry from the Changelog:

Enhancement - Allow access from document provider preference: [#3379](https://github.com/owncloud/android/issues/3379)

it does not make sense anymore, since the current one covers totally the final result.

[fesave]

(3)

Please, don't forget removing the following entry from the Changelog:

Enhancement - Allow access from document provider preference: [#3379](https://github.com/owncloud/android/issues/3379)

it does not make sense anymore, since the current one covers totally the final result.

Removed 😉

[fesave]

(3)

Please, don't forget removing the following entry from the Changelog:

Enhancement - Allow access from document provider preference: [#3379](https://github.com/owncloud/android/issues/3379)

it does not make sense anymore, since the current one covers totally the final result.

I think it's fixed, if you can test it thoroughly to make sure I'd appreciate it, anything you see, let me know.

[jesmrec]

Everything is correct!! approved on my side and right to 2.20