Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable logs by default in debug builds #3527

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Enable logs by default in debug builds #3527

merged 4 commits into from
Feb 1, 2022

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Jan 28, 2022 •
edited by jesmrec
Loading

Related Issues

App: #3526

QA

Checks done: #3527 (comment)

@abelgardep abelgardep self-assigned this Jan 28, 2022
@abelgardep abelgardep linked an issue Jan 28, 2022 that may be closed by this pull request
Logging is disabled by default during debug #3526
Closed
JuancaG05
JuancaG05 requested changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny suggestion here @abelgardep 👍

owncloudApp/src/main/java/com/owncloud/android/MainApp.kt Outdated Show resolved Hide resolved
@abelgardep abelgardep force-pushed the improvement/enable_logs_debug branch from 212e8ce to 37fff29 Compare January 31, 2022 10:49
JuancaG05
JuancaG05 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jesmrec jesmrec added this to the 2.20-current milestone Feb 1, 2022
@jesmrec
Copy link
Collaborator

jesmrec commented Feb 1, 2022

QA checks

  • Install debug variant from scratch -> Debug mode enabled
  • Install release variant from scratch -> Debug mode disabled
  • Upgrade debug enabled -> Debug mode enabled
  • Upgrade debug disabled -> Debug mode disabled
  • Upgrade release enabled -> Release mode enabled
  • Upgrade release disabled -> Release mode disabled

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 1, 2022

Approved on my side

@abelgardep abelgardep merged commit af056df into master Feb 1, 2022
@abelgardep abelgardep deleted the improvement/enable_logs_debug branch February 1, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannesa2 hannesa2 hannesa2 left review comments

@JuancaG05 JuancaG05 JuancaG05 approved these changes

@fesave fesave Awaiting requested review from fesave

Assignees

@abelgardep abelgardep

Labels
Approved by qa
Projects
None yet
Milestone
2.20
Development

Successfully merging this pull request may close these issues.

Logging is disabled by default during debug
4 participants
@abelgardep @jesmrec @hannesa2 @JuancaG05