Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrieve data from DB as LiveData has been implemented. #3461

Merged
merged 2 commits into from
Nov 25, 2021
Merged

Retrieve data from DB as LiveData has been implemented. #3461

merged 2 commits into from
Nov 25, 2021

Conversation

fesave
Copy link
Contributor

@fesave fesave commented Nov 25, 2021

Related Issues

App: #2869

@fesave fesave requested a review from jabarros November 25, 2021 07:56
@fesave fesave self-assigned this Nov 25, 2021
@fesave fesave mentioned this pull request Nov 25, 2021
Closed
52 tasks
abelgardep
abelgardep suggested changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions here @fesave

owncloudApp/src/main/java/com/owncloud/android/presentation/UIResult.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/UIResult.kt Outdated Show resolved Hide resolved
...p/src/main/java/com/owncloud/android/presentation/ui/files/filelist/MainFileListViewModel.kt Outdated Show resolved Hide resolved
...p/src/main/java/com/owncloud/android/presentation/ui/files/filelist/MainFileListViewModel.kt Outdated Show resolved Hide resolved
@fesave fesave requested a review from abelgardep November 25, 2021 09:05
abelgardep
abelgardep approved these changes Nov 25, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 864 Bugs
Vulnerability C 18 Vulnerabilities
Security Hotspot E 26 Security Hotspots
Code Smell A 5294 Code Smells

0.0% 0.0% Coverage
3.8% 3.8% Duplication

@fesave fesave merged commit 553cb37 into new_arch/file_list_isolation Nov 25, 2021
@fesave fesave deleted the new_arch/file_list_isolation_flow branch November 25, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abelgardep abelgardep abelgardep approved these changes

@jabarros jabarros Awaiting requested review from jabarros

Assignees

@fesave fesave

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fesave @abelgardep