[FEATURE] Respect capability for Avatar support.

[fesave]

Related Issues

App: #3285
Library: owncloud/android-library#442

• Added changelog files for the fixed issues in folder changelog/unreleased. More info here

---

QA

QA checklist: #3438 (comment)

[JuancaG05]

No syntax error found 🥇 , however, let's wait for @abelgardep to review this

[abelgardep]

Some suggestions here @fesave

[abelgardep]

Some suggestions here @fesave

[abelgardep]

Good job @fesave! Let's move it to QA

[jesmrec]

QA checks:

• "profile_picture": false -> avatar is not retrieved
• "profile_picture": true -> avatar is retrieved
• No "profile_picture" in response -> avatar is retrieved

[jesmrec]

(1) [FIXED]

Server returning

"user": {
            "expire_date": {
                   "enabled": false
            },
            "profile_picture": false,
            "send_mail": false
},

is also showing the avatar.

Nexus 6P
abced0f8

[fesave]

@jesmrec this is ready to test, but I have seen that sometimes the avatar call is called before the capabilities have been recovered. In the worst case the call is only made only once with this new check, avoiding saturating the server with constant calls.

[CLAassistant]

All committers have signed the CLA.

[jesmrec]

Regarding (1).

When browsing to root, the avatar endpoint request is done, no matter where do toy come from:

• From first login
• From other account
• Browsing back from any folder
• Using the Files tab
• From sharing view
• From settings view

will recheck this

[abelgardep]

It should be fixed now. @jesmrec

The avatar was retrieved from the SyncProfileOperation where we ask for the user info, user quota, and also avatar.

From now on, we will ask for the user info, user quota, and depending on the capability, we will ask for the avatar.

[jesmrec]

(1) is fixed.

Actually, capabilities are being moved to the new DB in the scope of the new architecture. For this reason, not every capability is supported with the new stuff yet. The current capability (profile_picture) is being refreshed together with the migrated ones, and that happens when browsing to the Sharing. That means, capability is not taken in account till user opens the Sharing view. This is like an intermediate status, that will be fixed when #3108 is implemented. Then, capabilities will keep the usual behaviour (updated when root folder is browsed)

With the current approach, this PR is ready to go.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information