Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MDM] Integrate Android Enterprise in the app #3419

Merged
merged 44 commits into from
Apr 27, 2022
Merged

[MDM] Integrate Android Enterprise in the app #3419

merged 44 commits into from
Apr 27, 2022

Conversation

JuancaG05
Copy link
Collaborator

@JuancaG05 JuancaG05 commented Oct 26, 2021 •
edited
Loading

Related Issues

App: #3415

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

@JuancaG05 JuancaG05 self-assigned this Oct 26, 2021
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JuancaG05 JuancaG05 linked an issue Oct 26, 2021 that may be closed by this pull request
[MDM] Integrate Android Enterprise in the app #3415
Closed
15 tasks
@JuancaG05 JuancaG05 marked this pull request as ready for review November 3, 2021 12:37
fesave
fesave suggested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@fesave fesave left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍🏻 , but I post some comments, check them out!

owncloudApp/src/main/java/com/owncloud/android/MainApp.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/authentication/LoginActivity.kt Outdated Show resolved Hide resolved
abelgardep
abelgardep suggested changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions here @JuancaG05

owncloudApp/src/main/java/com/owncloud/android/MainApp.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/authentication/LoginActivity.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/res/xml/managed_configurations.xml Outdated Show resolved Hide resolved
abelgardep
abelgardep suggested changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more questions here @JuancaG05

owncloudApp/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
owncloudApp/src/main/res/xml/managed_configurations.xml Show resolved Hide resolved
fesave
fesave approved these changes Nov 23, 2021
View reviewed changes
Copy link
Contributor

@fesave fesave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥇

abelgardep
abelgardep suggested changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last tiny change and we will be ready to go

owncloudApp/src/main/java/com/owncloud/android/presentation/ui/authentication/LoginActivity.kt Outdated Show resolved Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/ui/authentication/LoginActivity.kt Outdated Show resolved Hide resolved
@JuancaG05 JuancaG05 requested a review from abelgardep December 20, 2021 08:00
abelgardep
abelgardep approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@abelgardep abelgardep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First steps with MDM implemented, Well done @JuancaG05

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jesmrec jesmrec mentioned this pull request Feb 11, 2022
Closed
10 tasks
@abelgardep abelgardep force-pushed the feature/mdm branch 4 times, most recently from f3076f7 to 8e67fe6 Compare March 10, 2022 10:21
@abelgardep abelgardep mentioned this pull request Apr 25, 2022
Closed
9 tasks
JuancaG05 and others added 26 commits April 27, 2022 13:08
@JuancaG05 @abelgardep
Made MDM wording not translatable
5db5bd6
@JuancaG05 @abelgardep
Added new method contains to SharedPreferencesProvider
c5d6867
@JuancaG05 @abelgardep
MDM feedback is sent only if the managed configurations are new or ch…
92629ce 
…anged
@JuancaG05 @abelgardep
Calens file added
141460e
@JuancaG05 @abelgardep
Removed if else and added new OR condition to if
91c896f
@JuancaG05 @abelgardep
Created new MDM provider and managed configurations cached in provider
228f6a9
@JuancaG05 @abelgardep
Instantiated provider inside onCreate
e967f63
@JuancaG05 @abelgardep
Removed unused imports
82190a6
@abelgardep
Reformat a little bit the code
eacc9ca
@abelgardep
Use the mdm provider to retrieve the branded data
c04e5d8
@abelgardep
Update tests with the new branding provider
50cd5b0
@abelgardep
Calens changelog updated
7b3cbad
@abelgardep
Fix failing test
0b96f6f
@abelgardep
If we stop receiving the mdm configuration, start using the setup con…
e719b8d 
…figuration again
@abelgardep
Remove mdm application id suffix to allow upgrades from no mdm apps
90810fe
@abelgardep
Use empty as default value for server_url_configuration to avoid MDM …
4713149 
…wrong configs
@abelgardep
Cache a new mdm configuration for lock delay
7b97ea4
@abelgardep
Use the already cached lock delay value from MDM
ef14345
@abelgardep
Add the new lock delay restriction to the managed configurations xml
042f647
@abelgardep
Fix the way to save the lock delay enforcement
2d0cec4
@abelgardep
Use mdmProvider to retrieve setup values and fix some tests
2712a97
@abelgardep
Remove unused imports
465fdce
@abelgardep
Added logs to know the new and old values for each MDM restriction
4c61808
@abelgardep
MDM Option to allow or not screenshots
4df6c9b
@abelgardep
changelog
eac79c0
@abelgardep
StringDef
deb1e34
@abelgardep abelgardep merged commit 257640e into master Apr 27, 2022
@abelgardep abelgardep deleted the feature/mdm branch April 27, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fesave fesave fesave approved these changes

@abelgardep abelgardep abelgardep approved these changes

Assignees

@JuancaG05 JuancaG05

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[MDM] Integrate Android Enterprise in the app
4 participants
@JuancaG05 @CLAassistant @abelgardep @fesave