Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Account removed from "Settings" is not removed from the drawer #3381

Merged
merged 6 commits into from
Sep 20, 2021
Merged

[Fix] Account removed from "Settings" is not removed from the drawer #3381

merged 6 commits into from
Sep 20, 2021

Conversation

fesave
Copy link
Contributor

@fesave fesave commented Sep 14, 2021 •
edited
Loading

Related Issues

App: #3340

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

@fesave
UpdateAccountList() method was added to the listener to avoid a bug w…
85246da 
…hen the user removes an owncloud's account from the phone settings.
@fesave fesave self-assigned this Sep 14, 2021
@fesave fesave removed the request for review from theScrabi September 14, 2021 15:58
@fesave fesave linked an issue Sep 14, 2021 that may be closed by this pull request
[BUG] Account removed from "Settings" is not removed from the drawer #3340
Closed
@abelgardep abelgardep changed the base branch from master to fix/avoid_anr_with_files September 14, 2021 16:08
@fesave fesave changed the base branch from fix/avoid_anr_with_files to master September 14, 2021 16:24
@fesave fesave marked this pull request as ready for review September 15, 2021 06:02
@fesave fesave changed the base branch from master to fix/avoid_anr_with_files September 15, 2021 07:07
JuancaG05
JuancaG05 requested changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@JuancaG05 JuancaG05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, but it's up to you 👍

changelog/unreleased/3381 Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 703 Bugs
Vulnerability C 21 Vulnerabilities
Security Hotspot E 16 Security Hotspots
Code Smell A 3891 Code Smells

0.0% 0.0% Coverage
2.3% 2.3% Duplication

@jesmrec
Copy link
Collaborator

jesmrec commented Sep 20, 2021

Fixed.

@jesmrec jesmrec merged commit dfa0c44 into fix/avoid_anr_with_files Sep 20, 2021
@jesmrec jesmrec deleted the fix/account_removed_from_settings branch September 20, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuancaG05 JuancaG05 JuancaG05 approved these changes

@abelgardep abelgardep Awaiting requested review from abelgardep

Assignees

@fesave fesave

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Account removed from "Settings" is not removed from the drawer
3 participants
@fesave @jesmrec @JuancaG05