Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PKCE support #3310

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Add PKCE support #3310

merged 4 commits into from
Jul 14, 2021

Conversation

abelgardep
Copy link
Contributor

@abelgardep abelgardep commented Jul 14, 2021 •
edited
Loading

Related Issues

Library PR (if needed): owncloud/android-library#419

  • Added changelog files for the fixed issues in folder changelog/unreleased. More info here

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.18.1/PKCE%20Support.md

@abelgardep abelgardep self-assigned this Jul 14, 2021
@abelgardep abelgardep mentioned this pull request Jul 14, 2021
Merged
@abelgardep abelgardep force-pushed the improvement/oauth2_pkce branch from e0f3f10 to 79a25b6 Compare July 14, 2021 12:00
jabarros
jabarros approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@jabarros jabarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesmrec
Copy link
Collaborator

jesmrec commented Jul 14, 2021

From my side it is approved.

Tested against:

  • Test instances with PKCE
  • Regular OAuth2 server
  • oCIS test instance
  • oC10 basic auth server

@abelgardep abelgardep force-pushed the improvement/oauth2_pkce branch from 66e8db8 to dab16cf Compare July 14, 2021 16:44
@abelgardep abelgardep merged commit f9cb69b into master Jul 14, 2021
@abelgardep abelgardep deleted the improvement/oauth2_pkce branch July 14, 2021 17:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jabarros jabarros jabarros approved these changes

Assignees

@abelgardep abelgardep

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abelgardep @jesmrec @jabarros