[Feature] Fixed account for camera uploads #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
16 tasks
Closed
16 tasks
abelgardep
force-pushed
the
feature/camera_uploads_fixed_account
branch
from
897ff53 to
d2de681
Compare
JuancaG05
requested changes
May 10, 2021
There was a problem hiding this comment.
Some changes requested and comments here, but good job!! @abelgardep
...dTest/java/com/owncloud/android/settings/camerauploads/SettingsPictureUploadsFragmentTest.kt
Show resolved
Hide resolved
...dTest/java/com/owncloud/android/settings/camerauploads/SettingsPictureUploadsFragmentTest.kt
Show resolved
Hide resolved
...dTest/java/com/owncloud/android/settings/camerauploads/SettingsPictureUploadsFragmentTest.kt
Outdated
Show resolved
Hide resolved
...oidTest/java/com/owncloud/android/settings/camerauploads/SettingsVideoUploadsFragmentTest.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/files/services/CameraUploadsHandler.java
Outdated
Show resolved
Hide resolved
...va/com/owncloud/android/presentation/ui/settings/fragments/SettingsPictureUploadsFragment.kt
Show resolved
Hide resolved
...java/com/owncloud/android/presentation/ui/settings/fragments/SettingsVideoUploadsFragment.kt
Outdated
Show resolved
Hide resolved
...java/com/owncloud/android/presentation/ui/settings/fragments/SettingsVideoUploadsFragment.kt
Show resolved
Hide resolved
owncloudTestUtil/src/main/java/com/owncloud/android/testutil/OCAccount.kt
Show resolved
Hide resolved
|
Changes applied, ready for a second-round @JuancaG05 |
|
Test plan has already passed successfully. Focus was on the account uploads, not the camera uploads themselves. Camera uploads will be reviewed completely in the regression stage attached to the current version, just before releasing to the stores. |
abelgardep
force-pushed
the
feature/camera_uploads_fixed_account
branch
from
022940b to
95609bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #3166
Screenshots
QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.18/3226-Camera%20upload%20account.md
Reports: