[Feature] Settings accessible even when no account is attached #3218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
JuancaG05
force-pushed
the
feature/settings_login
branch
from
97c108a to
02a753e
Compare
JuancaG05
changed the title
abelgardep
suggested changes
May 4, 2021
There was a problem hiding this comment.
Some changes requested here @JuancaG05. By the way, tests are not passing, please take a look 👍
owncloudApp/src/androidTest/java/com/owncloud/android/settings/SettingsFragmentTest.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/androidTest/java/com/owncloud/android/settings/SettingsFragmentTest.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/androidTest/java/com/owncloud/android/settings/SettingsFragmentTest.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/utils/PermissionUtil.java
Outdated
Show resolved
Hide resolved
...src/test/java/com/owncloud/android/presentation/viewmodels/settings/SettingsViewModelTest.kt
Outdated
Show resolved
Hide resolved
...src/test/java/com/owncloud/android/presentation/viewmodels/settings/SettingsViewModelTest.kt
Outdated
Show resolved
Hide resolved
11 tasks
|
@abelgardep ready for review again |
…ted when trying to access "Logging" in login screen
JuancaG05
force-pushed
the
feature/settings_login
branch
from
8811fa1 to
faf4e6e
Compare
abelgardep
approved these changes
May 5, 2021
(1) [WONT FIX]In the feature description, we agreed this:
But, following these steps:
Current: Everything enabled as it was before removing the account Pixel 2 Android 11 |
|
fix for (1) will be developed in #3166 |
|
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #2638
QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Release_2.18/3218-Settings_login.md
Reports: