Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve thumbnails #3035

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Improve thumbnails #3035

merged 2 commits into from
Jan 15, 2021

Conversation

abelgardep
Copy link
Contributor

Implements #3024

@abelgardep abelgardep self-assigned this Dec 15, 2020
@abelgardep abelgardep marked this pull request as ready for review December 15, 2020 17:40
@abelgardep abelgardep requested a review from theScrabi December 15, 2020 17:40
@abelgardep abelgardep linked an issue Dec 16, 2020 that may be closed by this pull request
[FEATURE REQUEST] Improvements in preview/thumbnails updates #3024
Closed
8 tasks
@abelgardep abelgardep mentioned this pull request Dec 16, 2020
Closed
8 tasks
@jesmrec
Copy link
Collaborator

jesmrec commented Jan 12, 2021

Checks:

Non dowloaded files

  • Modify remote an image using a different client -> thumbnail is updated
  • Modify remote a txt file using a different client -> thumbnail is updated
  • Modify remote an image using a different client with no connection -> thumbnail is updated after recovering connection
  • Modify remote a txt file using a different client with no connection -> thumbnail is updated after recovering connection

Downloaded files

  • Modify remote an image using a different client -> thumbnail is updated
  • Modify remote a txt file using a different client -> thumbnail is updated
  • Modify remote an image using a different client with no connection -> thumbnail is updated after recovering connection
  • Modify remote a txt file using a different client with no connection -> thumbnail is updated after recovering connection
  • Modify locally a txt file -> file uploaded and thumbnail updated after open it
  • Modify locally a av. offline txt file -> file uploaded and thumbnail updated
  • Modify locally an image -> image uploaded and thumbnail updated after open it
  • Modify locally an av. offline image -> image uploaded and thumbnail updated

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 12, 2021 •
edited
Loading

New improvement: thumbnails are requested with same size so the shape does not usually match with the image shape. iOS app shows correctly thumbnails with no cuts. Any idea about it?

To illustrate:

right iOS, left Android. thumbnails are not scaled to image proportions

Screenshot 2021-01-13 at 14 50 56

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 14, 2021

Improvement above, addressed to a new issue #3050

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 14, 2021

Approved

@abelgardep abelgardep force-pushed the feature/improve_thumbnails branch from a18207e to 7718a9a Compare January 14, 2021 12:46
@abelgardep abelgardep force-pushed the feature/improve_thumbnails branch from 7718a9a to 07acc24 Compare January 15, 2021 13:33
@abelgardep abelgardep merged commit 3432112 into master Jan 15, 2021
@abelgardep abelgardep deleted the feature/improve_thumbnails branch January 15, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesmrec jesmrec jesmrec left review comments

@davigonz davigonz davigonz approved these changes

@theScrabi theScrabi Awaiting requested review from theScrabi

Assignees

@abelgardep abelgardep

Labels
Approved by qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Improvements in preview/thumbnails updates
3 participants
@abelgardep @jesmrec @davigonz