-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display thumbnail when file is image on FileDetailFragment #1065
Conversation
Hi @zmatsuo, thanks for your contribution. Thanks. |
I would postpone this till #1035 is merged as we then can enable preview also for videos. |
@tobiasKaminsky, @masensio detected that it would be great to include this pr for ui purposes so that the views are homogeneous, she is currently developing the new share with users view, because of that we have prioritized it. |
I've created a temporal branch for testing this PR: display_thumbnails_details_view_PR_1065 |
I tested this issue and it is not working: STEPS TO REPRODUCE:
ACTUAL BEHAVIOUR EXPECTED BEHAVIOUR ENVIROMENT |
@masensio @Dianafg76 I have created a PR for the branch, which @masensio has created. |
@tobiasKaminsky thanks for the fix! we will check it |
@zmatsuo, this PR was merged manually. Thanks everybody for the work. |
@masensio I think you have merged the wrong PR as a601a0e does not contain my changes in #1199 and they are necessary to fix the bug found by @Dianafg76 |
👍 |
Thumbnail is displayed instead of icon.
If small thumbnail on OCFileListFragment list view, go FileDetailFragment.
We can see bigger thumbnail. It's better.