Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display thumbnail when file is image on FileDetailFragment #1065

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Display thumbnail when file is image on FileDetailFragment #1065

merged 1 commit into from
Oct 15, 2015

Conversation

zmatsuo
Copy link
Contributor

@zmatsuo zmatsuo commented Jul 16, 2015

Thumbnail is displayed instead of icon.
If small thumbnail on OCFileListFragment list view, go FileDetailFragment.
We can see bigger thumbnail. It's better.

@zmatsuo zmatsuo changed the title Dispaly thumbnail when file is image Dispaly thumbnail when file is image on FileDetailFragment Jul 16, 2015
@zmatsuo zmatsuo mentioned this pull request Jul 16, 2015
@masensio
Copy link

masensio commented Oct 8, 2015

Hi @zmatsuo,

thanks for your contribution.
We want to have this contribution in the OwnCloud app. Could you update your contribution with the last version of the code?

Thanks.

@tobiasKaminsky tobiasKaminsky changed the title Dispaly thumbnail when file is image on FileDetailFragment Display thumbnail when file is image on FileDetailFragment Oct 8, 2015
@tobiasKaminsky
Copy link
Contributor

I would postpone this till #1035 is merged as we then can enable preview also for videos.
Btw: there are a lot of older PRs that should be merged earlier than this one, or?

@rperezb
Copy link

rperezb commented Oct 13, 2015

@tobiasKaminsky, @masensio detected that it would be great to include this pr for ui purposes so that the views are homogeneous, she is currently developing the new share with users view, because of that we have prioritized it.
Yes, we are aware of the videos ones, thanks!

@masensio
Copy link

I've created a temporal branch for testing this PR: display_thumbnails_details_view_PR_1065

@Dianafg76
Copy link

I tested this issue and it is not working:

STEPS TO REPRODUCE:

  1. there is a file downloaded
  2. Long press on the image
  3. Select details
  4. Go to the server with the same user
  5. You need another image with the same name
  6. Upload the new image
  7. Go to the mobil
  8. You are on details option
  9. Click in Refresh file option

ACTUAL BEHAVIOUR
You can't see the new thumbnail

EXPECTED BEHAVIOUR
The new thumbnail is shown

ENVIROMENT
.- Samsung Galaxy S3 v4.1.2
.- Nexus 9 v 5.1.1
.- Server v {"installed":true,"maintenance":false,"version":"8.2.0.9","versionstring":"8.2 RC1","edition":""}

@tobiasKaminsky
Copy link
Contributor

@masensio @Dianafg76 I have created a PR for the branch, which @masensio has created.
There you will find the fix @Dianafg76 has found.
As the new PR is writeable by us, I close this one in favour of the new one.

@rperezb
Copy link

rperezb commented Oct 15, 2015

@tobiasKaminsky thanks for the fix! we will check it

@masensio masensio reopened this Oct 15, 2015
@masensio masensio merged commit a601a0e into owncloud:develop Oct 15, 2015
@masensio
Copy link

@zmatsuo, this PR was merged manually.
Thanks for your contribution.

Thanks everybody for the work.

@tobiasKaminsky
Copy link
Contributor

@masensio I think you have merged the wrong PR as a601a0e does not contain my changes in #1199 and they are necessary to fix the bug found by @Dianafg76

@AndyScherzinger AndyScherzinger added this to the 1.8.1-current milestone Oct 21, 2015
@zmatsuo zmatsuo deleted the detailThumbnail branch November 2, 2015 14:19
@zmatsuo
Copy link
Contributor Author

zmatsuo commented Nov 2, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants