Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InstantUpload files duplicated in ownCloud folder #375

Closed
codeling opened this issue Feb 1, 2014 · 4 comments
Closed

InstantUpload files duplicated in ownCloud folder #375

codeling opened this issue Feb 1, 2014 · 4 comments

Comments

@codeling
Copy link

codeling commented Feb 1, 2014

After enabling the InstantUpload feature, all photo files seem to be duplicated by the client - they exist once in their original location in the DCIM folder, and once in the /owncloud/user@ochost/(Instant|Sofort)Upload folder.
This seems redundant to me - I don't see any use in having those duplicate files? The only thing I can think of which such a copy could achieve would be marking which files are successfully uploaded? But there surely is a simpler way of doing that than to just copy the file? Maybe store a file with the same name as the image plus e.g. .hash suffix, containing a hash of the uploaded file?
Those copies just wastes a lot of space on my (non-extensible) internal storage.

Using the latest version available in Market (1.4.3).
Server version is 6.0.1 (but is going on since 5.0.13 at least).

@masensio
Copy link

When you activate the InstantUpload feature and take the photo, the app creates a copy of the photo in its IntantUploads folder and uploads it to the server.
The app needs to storage the image into InstantUploads folder, because this folder shows the content of the InstantUploads folder of the server. This causes that the files are duplicated, you are right.

Maybe there could be other options for implementing this feature, not including duplication of images.

For now, to avoid this duplication, you can select with a long press on InstantUploads folder: delete -> local content only, regularly.
In this way you will have your images in your server and in your camera folder.

I hope this can help you with your storage problem.

@davivel
Copy link
Contributor

davivel commented Feb 13, 2014

The files are copied because it's the easiest way to avoid problems when a user has several accounts, uploads the same file to different accounts, mark both as kept-in-sync and tries to update them in different ways.

Yes, it's a complex situation and we could handle it better. But when we had to implement in the past we didn't have time for more.

And it's duplicating #346, since the policy is for all the uploaded files, not just instant uploads. So please, track it there.

@davivel davivel closed this as completed Feb 13, 2014
@codeling
Copy link
Author

Oh, must've missed the other issue, I'll be watching that! Thanks for the great work.

@Bugsbane
Copy link

Might be helped by pull #919 Not sure.

hannesa2 pushed a commit that referenced this issue Oct 9, 2023
…-1.4.31

Bump kotlinVersion from 1.4.30 to 1.4.31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants