Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple files: improve copy/move dialog #1414

Closed
elpraga opened this issue Jan 9, 2016 · 13 comments · Fixed by #3640
Closed

Multiple files: improve copy/move dialog #1414

elpraga opened this issue Jan 9, 2016 · 13 comments · Fixed by #3640
Assignees
Milestone

Comments

@elpraga
Copy link

elpraga commented Jan 9, 2016

They appear exactly the same and there is no way of knowing which is which as they appear only as an icon without any text

@AndyScherzinger
Copy link
Contributor

@elpraga can you check with the latest release (today) 20150109 since I have replaced the icons there and copy to and move to should be distinguishable :)

@elpraga
Copy link
Author

elpraga commented Jan 9, 2016

I can confirm. @AndyScherzinger in 20150109 the icons can be distinguished.

Do You think it would be nice to add "copy to" and "move to" respectively to the select folder dialog? Maybe just left from the three dots menu on the top right? This is just an idea though, if You feel like it is not good idea or it would be too much work to implement it, we can close the issue

@tobiasKaminsky
Copy link
Contributor

For me there are no icons? The list, which is opened after clicking the three dots, shows only text?

@AndyScherzinger
Copy link
Contributor

@tobiasKaminsky there should be ;) - what @elpraga means are the following icons you can see in the screenshots in #1411

@AndyScherzinger
Copy link
Contributor

@elpraga can you provide some more details on the select folder comment? From what I understand you want to move/copy files from within a folder chooser. If so I would recommend against it since it mixed we the actions one would expect in the context of choosing. So imho when selecting a folder, selecting a folder should be the only action (except for creating a folder though)

@elpraga
Copy link
Author

elpraga commented Jan 9, 2016

I will as soon as I get home in a little bit. The chance in icons you made
in 20160109 was great.
My last suggestion was to add an informative text in the choose folder
dialog that appears after clicking on respective icon.

If you click on the copy icon for example, the dialog that appears would
say "copy to" in the top part, just informing what are we selecting the
folder for.

But as I mentioned before, I don't see it crucially important. I just
think It would be nice if it doesn't require almost any extra work.
El 9 ene. 2016 5:44 p. m., "Andy Scherzinger" [email protected]
escribió:

@elpraga https://github.com/elpraga can you provide some more details
on the select folder comment? From what I understand you want to move/copy
files from within a folder chooser. If so I would recommend against it
since it mixed we the actions one would expect in the context of choosing.
So imho when selecting a folder, selecting a folder should be the only
action (except for creating a folder though)


Reply to this email directly or view it on GitHub
#1414 (comment).

@AndyScherzinger
Copy link
Contributor

Ah, now I get what you mean, sorry! This shouldn't be to much work to be implemented imho and yes, this would totally make sense. But that is also just my opinion. @tobiasKaminsky @jancborchardt what do you think? I vote yes on implementing this. copy/move in the title to show this context information.

@tobiasKaminsky
Copy link
Contributor

This is a good idea.
cc @jancborchardt for the exact wording

@jancborchardt
Copy link
Member

Yeah, good call. »Copy file/foldername to« and »Move file/foldername to« in the header woulf be good wording.

Additionally if possible, it's always good to show the thumbnail of the file/folder to the left in that modal header. And have a relevant label for the button, like »Copy« / »Move«.

@AndyScherzinger
Copy link
Contributor

@jancborchardt be aware that you can have a multiple selection and then hit move/copy so the (list of) files/folders wouldn't make sense the action bar title... :)

@tobiasKaminsky
Copy link
Contributor

@jancborchardt
Copy link
Member

Good call – show the first 3 of them in this stacked way, and then in the title say »Move 21 files to …«

@tobiasKaminsky tobiasKaminsky changed the title Beta 20150103: When multiple files selected, Copy to and Move to icons are identical and cannot be distinguished Multiple files: improve copy/move dialog Mar 14, 2016
@tobiasKaminsky
Copy link
Contributor

I have updated the title and removed the label as the latest idea by @jancborchardt is not related to beta any longer but a new idea for the dialogs.

@fesave fesave self-assigned this Apr 27, 2022
@fesave fesave added this to the 2.21-current milestone Apr 27, 2022
@fesave fesave linked a pull request Apr 27, 2022 that will close this issue
1 task
@jesmrec jesmrec removed the Sprint label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants