Skip to content

Commit

Permalink
Merge pull request #4376 from owncloud/technical/kotlinize_text_preview
Browse files Browse the repository at this point in the history
[TECHNICAL] Kotlinize PreviewTextFragment
  • Loading branch information
joragua authored Apr 25, 2024
2 parents 17c6782 + a94a143 commit 1be13d1
Show file tree
Hide file tree
Showing 6 changed files with 463 additions and 539 deletions.
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,11 @@ ownCloud admins and users.
* Bugfix - "Clear data" button enabled in the app settings in device settings: [#4309](https://github.com/owncloud/android/issues/4309)
* Bugfix - Remove lens icon in folder picker: [#4311](https://github.com/owncloud/android/issues/4311)
* Bugfix - Retried successful uploads are cleaned up from the temporary folder: [#4335](https://github.com/owncloud/android/issues/4335)
* Bugfix - Resolve incorrect truncation of long display names in Manage Accounts: [#4351](https://github.com/owncloud/android/issues/4351)
* Change - Upgrade minimum SDK version to Android 7.0 (v24): [#4230](https://github.com/owncloud/android/issues/4230)
* Change - Automatic discovery of the account in login: [#4301](https://github.com/owncloud/android/issues/4301)
* Change - Add new prefixes in commit messages of 3rd party contributors: [#4346](https://github.com/owncloud/android/pull/4346)
* Change - Kotlinize PreviewTextFragment: [#4356](https://github.com/owncloud/android/issues/4356)
* Enhancement - Correct "Local only" option in remove dialog: [#3936](https://github.com/owncloud/android/issues/3936)
* Enhancement - Improvements in Manage Accounts view: [#4148](https://github.com/owncloud/android/issues/4148)
* Enhancement - New setting for manual removal of local storage: [#4174](https://github.com/owncloud/android/issues/4174)
Expand Down Expand Up @@ -71,6 +73,15 @@ ownCloud admins and users.
https://github.com/owncloud/android/issues/4335
https://github.com/owncloud/android/pull/4341

* Bugfix - Resolve incorrect truncation of long display names in Manage Accounts: [#4351](https://github.com/owncloud/android/issues/4351)

Resolved the bug where long display names were truncated incorrectly in the
Manage Accounts view. Now, display names are properly truncated in the middle
with ellipsis (...) to maintain readability.

https://github.com/owncloud/android/issues/4351
https://github.com/owncloud/android/pull/4380

* Change - Upgrade minimum SDK version to Android 7.0 (v24): [#4230](https://github.com/owncloud/android/issues/4230)

The minimum Android version will be Android 7.0 Nougat (API 24). The application
Expand All @@ -94,6 +105,13 @@ ownCloud admins and users.

https://github.com/owncloud/android/pull/4346

* Change - Kotlinize PreviewTextFragment: [#4356](https://github.com/owncloud/android/issues/4356)

PreviewTextFragment class has been moved from Java to Kotlin.

https://github.com/owncloud/android/issues/4356
https://github.com/owncloud/android/pull/4376

* Enhancement - Correct "Local only" option in remove dialog: [#3936](https://github.com/owncloud/android/issues/3936)

"Local only" option in remove dialog will only be shown if checking selected
Expand Down
2 changes: 1 addition & 1 deletion changelog/unreleased/4351
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Bugfix: Resolve incorrect truncation of long display names in Manage Accounts view
Bugfix: Resolve incorrect truncation of long display names in Manage Accounts

Resolved the bug where long display names were truncated incorrectly in the Manage Accounts view.
Now, display names are properly truncated in the middle with ellipsis (...) to maintain readability.
Expand Down
6 changes: 6 additions & 0 deletions changelog/unreleased/4376
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Change: Kotlinize PreviewTextFragment

PreviewTextFragment class has been moved from Java to Kotlin.

https://github.com/owncloud/android/issues/4356
https://github.com/owncloud/android/pull/4376
Original file line number Diff line number Diff line change
Expand Up @@ -1561,7 +1561,7 @@ class FileDisplayActivity : FileActivity(),
*
* @param file Text [OCFile] to preview.
*/
fun startTextPreview(file: OCFile?) {
fun startTextPreview(file: OCFile) {
val textPreviewFragment = PreviewTextFragment.newInstance(
file,
account
Expand Down
Loading

0 comments on commit 1be13d1

Please sign in to comment.