Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

[New arch] Delete public share #250

Merged
merged 1 commit into from
Jun 3, 2019
Merged

[New arch] Delete public share #250

merged 1 commit into from
Jun 3, 2019

Conversation

davigonz
Copy link
Contributor

@davigonz davigonz commented May 10, 2019 •
edited
Loading

@davigonz davigonz changed the base branch from master to new_arch/shares May 10, 2019 11:25
This was referenced May 10, 2019
Merged
Closed
@davigonz davigonz force-pushed the new_arch/delete_public_share branch from 29ee93e to 2cbc321 Compare May 15, 2019 11:18
@davigonz davigonz force-pushed the new_arch/shares branch 2 times, most recently from 0a353d5 to b20bf8c Compare May 24, 2019 11:39
@davigonz davigonz changed the title [New arch] Delete public share [WIP] [New arch] Delete public share May 24, 2019
jcmontesmartos
jcmontesmartos approved these changes May 30, 2019
View reviewed changes
Copy link

@jcmontesmartos jcmontesmartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davigonz davigonz self-assigned this May 30, 2019
@davigonz davigonz merged commit 4ec206f into new_arch/shares Jun 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the new_arch/delete_public_share branch June 3, 2019 06:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcmontesmartos jcmontesmartos jcmontesmartos approved these changes

Assignees

@davigonz davigonz

Labels
code approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davigonz @jcmontesmartos