Skip to content
This repository has been archived by the owner on Mar 19, 2024. It is now read-only.

code cleanup #235

Merged
merged 2 commits into from
Nov 12, 2019
Merged

code cleanup #235

merged 2 commits into from
Nov 12, 2019

Conversation

hannesa2
Copy link
Contributor

Inspired by conflicted and non-maintained #186 I did same with this PR, to be able to close #186 when this is done

@davigonz davigonz added this to the 1.1 milestone Feb 14, 2019
@hannesa2 hannesa2 force-pushed the cleanupCode branch 3 times, most recently from adbf6da to 690805f Compare March 13, 2019 21:31
@hannesa2 hannesa2 mentioned this pull request Mar 15, 2019
@hannesa2 hannesa2 force-pushed the cleanupCode branch 2 times, most recently from 2f80c53 to 0a93895 Compare August 11, 2019 08:18
@hannesa2
Copy link
Contributor Author

hannesa2 commented Oct 30, 2019

Hey guys it's approved since 50 days, what's about to merge it ?

@hannesa2 hannesa2 removed the request for review from davigonz November 1, 2019 17:40
@davigonz
Copy link
Contributor

davigonz commented Nov 5, 2019

Hi @hannesa2 , we will take it into account in our next planning.

@davigonz davigonz added the Sprint label Nov 7, 2019
@jesmrec
Copy link
Collaborator

jesmrec commented Nov 12, 2019

Built correctly. Tested together with master in the app module (c2d0e860)

Approved.

@abelgardep abelgardep merged commit 07e00a7 into owncloud:master Nov 12, 2019
@hannesa2 hannesa2 deleted the cleanupCode branch November 12, 2019 18:49
@jesmrec jesmrec removed the Sprint label Nov 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants