Android Studio 3.2.1 #198

hannesa2 · 2018-10-24T06:23:00Z

hannesa2 · 2018-10-24T06:40:13Z

build.gradle

@@ -1,10 +1,10 @@
 buildscript {
    repositories {
-        jcenter()


I guess this should be merged to make PR owncloud/android#2324 on main repo work.
Additional #199 needs it

davigonz · 2018-10-24T13:35:39Z

build.gradle

@@ -27,6 +27,10 @@ dependencies {
 android {
    compileSdkVersion 26

+    defaultConfig {
+        minSdkVersion 14


Why have you moved the minSdkVersion and not the compileSdkVersion? Is there any difference between setting this in build.gradle or in AndroidManifest.xml?

most recent Android Studio complain about having this values in AndroidManifest.xml It's a relict form Eclipse, which is not more supported since ~ 2016.09
It should be located in 'build.gradle'

It's related to #180 which removes Eclipse (or did it as I created the PR long time ago)

I see, can you move also the targetSdkVersion here?

davigonz · 2018-10-24T13:36:20Z

Hi @hannesa2 , thank you for helping us with this dependencies update, I put a comment in the review.

davigonz · 2018-10-25T06:46:18Z

build.gradle

@@ -27,6 +27,10 @@ dependencies {
 android {
    compileSdkVersion 26

+    defaultConfig {
+        minSdkVersion 14


I see, can you move also the targetSdkVersion here?

hannesa2 · 2018-10-25T07:11:13Z

It's hard to smell whats too much or too less.
The focus of this PR is Android Studio 3.2.1 and I did only necessary (remove red Gradle hints) steps doing so.

But yes, I will do. But any further step should be done in additional PRs

owncloud#198 (comment)

davigonz · 2018-10-25T12:53:42Z

@hannesa2 I have cloned your code and is not compiling because minSdkVersion of test_client project is still in AndroidManifest.xml, can you fix that? Thanks

hannesa2 · 2018-10-25T13:33:28Z

sample_client/AndroidManifest.xml

@@ -29,9 +29,6 @@
          android:versionName="1.0">

    <uses-permission android:name="android.permission.INTERNET"/>
-    <uses-sdk
-        android:minSdkVersion="14"


it's deleted !

hannesa2 · 2018-10-25T13:33:58Z

@davigonz
"of test_client project is still in AndroidManifest.xml" ... sorry it's removed.
https://github.com/owncloud/android-library/pull/198/files#r228174090

Please double check your test, I'm receiving a

BUILD SUCCESSFUL in 49s
163 actionable tasks: 160 executed, 3 up-to-date

during ./gradlew clean build in lib and I'm able to start as well

Travis is green too

hannesa2 · 2018-10-26T06:11:36Z

Ahhh ! There is a sample_client and a test_client.
Wtf, this should someone understand, there is no hint in README and in Travis it's comment out.

It's dead code !

It builds and starts without modification
It's dead code: so an other PR should use/fix it or simple delete it

hannesa2 · 2018-10-26T06:23:48Z

Btw test_client uses ActivityInstrumentationTestCase2

I see following way:

you push merge on all merge-able PR (immediate without finding other dead stuff)
I convert to Gradle-only (without any Eclipse)
If a guy has fun, convert this tests to Espresso tests and use it in Travis (PR needs much longer because of ARM)
Then we have a good base and I like to see it with right tags to use as a normal maven dependency
via jitpack.io https://jitpack.io/#owncloud/android-library in any Android project

... but step by step. Start with 1

owncloud#198 (comment)

hannesa2 · 2018-11-07T20:08:22Z

Version 2.9 is out, what's about some progress here, or is it postponed to 20XX ?

davigonz · 2018-11-08T08:33:38Z

Version 2.9 is out, what's about some progress here, or is it postponed to 20XX ?

@hannesa2 this is scheduled for 2.10, as you can see in the issue connected to this PR (owncloud/android#2327)

davigonz · 2018-11-08T12:20:28Z

Let's follow this way @hannesa2:

Get rid of old ant tests via Get rid of old ant tests #211 ✅
Merge this
Remove Eclipse structure

owncloud#198 (comment)

davigonz · 2018-11-09T08:42:03Z

@hannesa2 old tests deletion got merged, can you please rebase this to move it forward?

owncloud#198 (comment)

hannesa2 · 2018-11-09T14:30:40Z

The system is wrong, when you can successfully merge a PR and follow up is blocked because something is missing. Btw, this security/snyk is unknown to me

davigonz · 2018-11-12T08:47:33Z

@DeepDiver1975 we are able to merge our PRs but we keep seeing the warning about security/snyk with test_client when it doesn't exist anymore, is there any way to avoid those checks?

Note: we don't need this PR to be merged yet 😄

hannesa2 · 2018-11-13T04:56:45Z

"Note: we don't need this PR to be merged yet 😄" ... maybe from technical reason when you happy with current situation. -I'm not-

Seeing the speed here, I'm not surprised, when it will merged, when 3.3 is out

owncloud#198 (comment)

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from 31f974c to bd5daef Compare October 24, 2018 06:29

hannesa2 commented Oct 24, 2018

View reviewed changes

This was referenced Oct 24, 2018

Android Studio 3.2.1 owncloud/android#2324

Merged

Update Kotlin #199

Closed

davigonz added this to the 0.9.21 milestone Oct 24, 2018

davigonz assigned hannesa2 Oct 24, 2018

davigonz reviewed Oct 24, 2018

View reviewed changes

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from 1a20c10 to 4b125d4 Compare October 25, 2018 04:43

davigonz suggested changes Oct 25, 2018

View reviewed changes

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from 4b125d4 to 43345b5 Compare October 25, 2018 07:17

hannesa2 added a commit to hannesa2/android-library that referenced this pull request Oct 25, 2018

apply review comment concerning targetSdkVersion

43345b5

owncloud#198 (comment)

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from 43345b5 to 2e9ef26 Compare October 25, 2018 07:29

hannesa2 added a commit to hannesa2/android-library that referenced this pull request Oct 25, 2018

apply review comment concerning targetSdkVersion

2e9ef26

owncloud#198 (comment)

davigonz approved these changes Oct 25, 2018

View reviewed changes

davigonz mentioned this pull request Oct 25, 2018

Android Studio 3.2.1 + Gradle update owncloud/android#2327

Closed

hannesa2 commented Oct 25, 2018

View reviewed changes

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from 2e9ef26 to eec584c Compare October 27, 2018 10:23

hannesa2 added a commit to hannesa2/android-library that referenced this pull request Oct 27, 2018

apply review comment concerning targetSdkVersion

eec584c

owncloud#198 (comment)

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from eec584c to 54484d9 Compare October 30, 2018 06:26

hannesa2 added a commit to hannesa2/android-library that referenced this pull request Oct 30, 2018

apply review comment concerning targetSdkVersion

54484d9

owncloud#198 (comment)

davigonz removed this from the 0.9.21 milestone Nov 8, 2018

davigonz mentioned this pull request Nov 8, 2018

Get rid of old ant tests #211

Merged

davigonz mentioned this pull request Nov 8, 2018

Get rid of old ant tests in library owncloud/android#2343

Merged

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from 54484d9 to 6574b67 Compare November 8, 2018 22:26

hannesa2 added a commit to hannesa2/android-library that referenced this pull request Nov 8, 2018

apply review comment concerning targetSdkVersion

6574b67

owncloud#198 (comment)

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from 6574b67 to d2e6327 Compare November 9, 2018 14:27

hannesa2 added a commit to hannesa2/android-library that referenced this pull request Nov 9, 2018

apply review comment concerning targetSdkVersion

d2e6327

owncloud#198 (comment)

davigonz added the code approved label Nov 19, 2018

hannesa2 mentioned this pull request Nov 20, 2018

Sorting options in sharing view owncloud/android#2307

Merged

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from d2e6327 to 194feae Compare November 20, 2018 18:52

hannesa2 added a commit to hannesa2/android-library that referenced this pull request Nov 20, 2018

apply review comment concerning targetSdkVersion

194feae

owncloud#198 (comment)

hannesa2 added 2 commits November 27, 2018 11:39

Android Studio 3.2.1

6eba501

apply review comment concerning targetSdkVersion

94f3c37

owncloud#198 (comment)

hannesa2 force-pushed the AndroidStudio-3.2.1 branch from 194feae to 94f3c37 Compare November 27, 2018 10:39

davigonz merged commit 9502498 into owncloud:master Nov 29, 2018

hannesa2 deleted the AndroidStudio-3.2.1 branch November 30, 2018 06:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android Studio 3.2.1 #198

Android Studio 3.2.1 #198

hannesa2 commented Oct 24, 2018 •

edited by davigonz

Loading

hannesa2 Oct 24, 2018 •

edited

Loading

davigonz Oct 24, 2018

hannesa2 Oct 24, 2018

davigonz Oct 25, 2018

davigonz commented Oct 24, 2018

davigonz Oct 25, 2018

hannesa2 commented Oct 25, 2018

davigonz commented Oct 25, 2018

hannesa2 Oct 25, 2018

hannesa2 commented Oct 25, 2018 •

edited

Loading

hannesa2 commented Oct 26, 2018

hannesa2 commented Oct 26, 2018 •

edited

Loading

hannesa2 commented Nov 7, 2018

davigonz commented Nov 8, 2018

davigonz commented Nov 8, 2018 •

edited

Loading

davigonz commented Nov 9, 2018

hannesa2 commented Nov 9, 2018 •

edited

Loading

davigonz commented Nov 12, 2018

hannesa2 commented Nov 13, 2018

Android Studio 3.2.1 #198

Android Studio 3.2.1 #198

Conversation

hannesa2 commented Oct 24, 2018 • edited by davigonz Loading

hannesa2 Oct 24, 2018 • edited Loading

Choose a reason for hiding this comment

davigonz Oct 24, 2018

Choose a reason for hiding this comment

hannesa2 Oct 24, 2018

Choose a reason for hiding this comment

davigonz Oct 25, 2018

Choose a reason for hiding this comment

davigonz commented Oct 24, 2018

davigonz Oct 25, 2018

Choose a reason for hiding this comment

hannesa2 commented Oct 25, 2018

davigonz commented Oct 25, 2018

hannesa2 Oct 25, 2018

Choose a reason for hiding this comment

hannesa2 commented Oct 25, 2018 • edited Loading

hannesa2 commented Oct 26, 2018

hannesa2 commented Oct 26, 2018 • edited Loading

hannesa2 commented Nov 7, 2018

davigonz commented Nov 8, 2018

davigonz commented Nov 8, 2018 • edited Loading

davigonz commented Nov 9, 2018

hannesa2 commented Nov 9, 2018 • edited Loading

davigonz commented Nov 12, 2018

hannesa2 commented Nov 13, 2018

hannesa2 commented Oct 24, 2018 •

edited by davigonz

Loading

hannesa2 Oct 24, 2018 •

edited

Loading

hannesa2 commented Oct 25, 2018 •

edited

Loading

hannesa2 commented Oct 26, 2018 •

edited

Loading

davigonz commented Nov 8, 2018 •

edited

Loading

hannesa2 commented Nov 9, 2018 •

edited

Loading