Replace network library #192

davigonz · 2018-06-07T14:57:32Z

Implements #51
Needs owncloud/android#2236

davigonz · 2018-08-06T07:37:00Z

build.gradle

+    api project(':dav4android')
+
+    // Used for network and database debuging
+    debugApi 'com.facebook.stetho:stetho:1.5.0'


Delete Stetho, with Android Studio network profiler is enough

davigonz · 2018-08-06T07:41:46Z

sample_client/AndroidManifest.xml

-            android:screenOrientation="portrait"
-            >
+    <application android:label="@string/app_name" android:icon="@drawable/ic_launcher">
+        <activity 	android:name="MainActivity"


Indent this properly

davigonz · 2018-08-06T07:59:36Z

src/com/owncloud/android/lib/common/OwnCloudClient.java

+import com.owncloud.android.lib.common.http.HttpClient;
+import com.owncloud.android.lib.common.http.HttpConstants;
+import com.owncloud.android.lib.common.http.methods.HttpBaseMethod;
+import com.owncloud.android.lib.common.http.methods.webdav.CopyMethod;


Import not used

davigonz · 2018-08-06T07:59:53Z

src/com/owncloud/android/lib/common/OwnCloudClient.java

+import java.util.List;
+
+import at.bitfire.dav4android.exception.HttpException;
+import at.bitfire.dav4android.exception.RedirectException;


Neither this

davigonz · 2018-08-06T08:05:12Z

src/com/owncloud/android/lib/common/OwnCloudClient.java

-            PARAM_SINGLE_COOKIE_HEADER,             // to avoid problems with some web servers
-            PARAM_SINGLE_COOKIE_HEADER_VALUE
-        );
+        //TODO


Check if this is implemented somewhere else and delete it if so

davigonz · 2018-08-06T08:56:37Z

src/com/owncloud/android/lib/common/authentication/oauth/BearerCredentials.java

@@ -24,16 +24,15 @@



Update copyright year

davigonz · 2018-08-06T08:58:23Z

src/com/owncloud/android/lib/common/authentication/oauth/OAuth2GetAccessTokenOperation.java

@@ -31,21 +31,21 @@
 import com.owncloud.android.lib.common.authentication.OwnCloudBasicCredentials;


Same here, including authors

davigonz · 2018-08-06T08:59:11Z

src/com/owncloud/android/lib/common/authentication/oauth/OAuth2RefreshAccessTokenOperation.java

@@ -26,19 +26,22 @@
 import com.owncloud.android.lib.common.authentication.OwnCloudBasicCredentials;


davigonz · 2018-08-06T09:01:37Z

src/com/owncloud/android/lib/common/authentication/oauth/OAuth2RefreshAccessTokenOperation.java

-            OwnCloudCredentials oldCredentials = switchClientCredentials(oauthCredentials);
-
-            client.executeMethod(postMethod);
+            final OwnCloudCredentials oauthCredentials =


This fits properly in the same line

davigonz · 2018-08-06T09:05:38Z

src/com/owncloud/android/lib/common/http/methods/HttpBaseMethod.java

+        return mCall.isCanceled();
+    }
+
+


Too much space here

davigonz · 2018-08-06T10:17:50Z

test_client/src/com/owncloud/android/lib/test_project/SelfSignedConfidentSslSocketFactory.java

@@ -41,12 +41,6 @@
 import javax.net.ssl.TrustManagerFactory;


Update copyright year in all test classes

davigonz · 2018-08-06T10:30:30Z

src/com/owncloud/android/lib/resources/users/GetRemoteUserInfoOperation.java

-            get = new GetMethod(client.getBaseUri() + OCS_ROUTE);
-            get.addRequestHeader(OCS_API_HEADER, OCS_API_HEADER_VALUE);
-            status = client.executeMethod(get);
+            final Request request = new Request.Builder()


This request is not being used

davigonz · 2018-08-06T10:31:02Z

src/com/owncloud/android/lib/resources/users/GetRemoteUserInfoOperation.java

+
+import java.net.URL;
+
+import okhttp3.Request;


Not needed since due to next comment

davigonz · 2018-08-06T10:31:30Z

src/com/owncloud/android/lib/resources/users/GetRemoteUserAvatarOperation.java

 import com.owncloud.android.lib.common.OwnCloudClient;
+import com.owncloud.android.lib.common.http.HttpConstants;
+import com.owncloud.android.lib.common.http.methods.nonwebdav.GetMethod;
 import com.owncloud.android.lib.common.network.WebdavUtils;
 import com.owncloud.android.lib.common.operations.RemoteOperation;
 import com.owncloud.android.lib.common.operations.RemoteOperationResult;
 import com.owncloud.android.lib.common.utils.Log_OC;



Too much space here

davigonz · 2018-08-06T10:37:35Z

src/com/owncloud/android/lib/resources/users/GetRemoteUserAvatarOperation.java

-                result = new RemoteOperationResult(false, get);
-                client.exhaustResponse(get.getResponseBodyAsStream());
+                result = new RemoteOperationResult<>(getMethod);
+                client.exhaustResponse(getMethod.getResponseAsStream());


getResponseAsStream => getResponseBodyAsStream

davigonz · 2018-08-06T11:00:17Z

src/com/owncloud/android/lib/resources/files/ExistenceCheckRemoteOperation.java

@@ -1,140 +1,138 @@
 /* ownCloud Android Library is available under MIT license
 *   Copyright (C) 2016 ownCloud GmbH.


Update this year

davigonz · 2018-08-06T11:02:46Z

src/com/owncloud/android/lib/resources/files/CreateRemoteFolderOperation.java

@@ -87,39 +92,38 @@ protected RemoteOperationResult run(OwnCloudClient client) {
            }

        } else {
-            result = new RemoteOperationResult(ResultCode.INVALID_CHARACTER_IN_NAME);
+            result = new RemoteOperationResult<>(ResultCode.INVALID_CHARACTER_IN_NAME);
        }

        return result;
    }



Too much space here

davigonz · 2018-08-06T11:03:49Z

src/com/owncloud/android/lib/resources/files/CopyRemoteFileOperation.java

-     * @throws org.apache.jackrabbit.webdav.DavException If the status code is other than MultiStatus or if obtaining
-     *                                                   the response XML document fails
-     */
-    private RemoteOperationResult processPartialError(CopyMethod copyMethod)


Have a look at this

davigonz · 2018-08-06T11:04:15Z

src/com/owncloud/android/lib/resources/files/CopyRemoteFileOperation.java

@@ -27,25 +27,21 @@
 import android.util.Log;


Update copyright year

davigonz · 2018-08-06T11:06:45Z

src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java

@@ -1,29 +1,16 @@
-/* ownCloud Android Library is available under MIT license


Include this again

jabarros · 2018-08-09T08:25:34Z

src/com/owncloud/android/lib/resources/files/DownloadRemoteFileOperation.java

                        mModificationTimestamp = (d != null) ? d.getTime() : 0;
                    } else {
                        Log_OC.e(TAG, "Could not read modification time from response downloading " + mRemotePath);
                    }

-                    mEtag = WebdavUtils.getEtagFromResponse(mGet);
+                    // TODO mEtag = WebdavUtils.getEtagFromResponse(mGet);
                    if (mEtag.length() == 0) {


It always will be zero. Don't you nedd implement TODO?

Let me check...

Yes, I will implement the TODO

jabarros · 2018-08-09T08:26:01Z

LGTM

add OCAccount

…t operation

theScrabi · 2018-10-09T17:02:47Z

davigonz mentioned this pull request Jun 7, 2018

Replace network library owncloud/android#2236

Merged

20 tasks

davigonz self-assigned this Jun 7, 2018

davigonz force-pushed the replace_network_library branch from 0b5ea8e to 7274358 Compare June 12, 2018 15:42

theScrabi force-pushed the replace_network_library branch from b736484 to cbbdc2c Compare June 13, 2018 12:14

davigonz force-pushed the replace_network_library branch from cbbdc2c to 868079e Compare June 13, 2018 15:15

davigonz force-pushed the replace_network_library branch 2 times, most recently from 01d5993 to 7529026 Compare June 29, 2018 12:20

davigonz force-pushed the replace_network_library branch from f890d8f to 4cbfc4a Compare July 18, 2018 09:49

davigonz commented Aug 6, 2018

View reviewed changes

davigonz force-pushed the replace_network_library branch from f4aba99 to 4d2d584 Compare August 7, 2018 15:24

davigonz changed the title ~~[WIP] Replace network library~~ Replace network library Aug 7, 2018

jabarros reviewed Aug 9, 2018

View reviewed changes

davigonz force-pushed the replace_network_library branch from b0b83ce to 8e30a3b Compare August 30, 2018 09:04

theScrabi and others added 15 commits September 4, 2018 13:38

add dav4droid support part1

cd3d20d

ren owncloud to OC

e354a71

add OCAccount

1249e20

add OCAccount

First propfind using dav4droid and new architecture

3125c80

Solve conflicts

ff6adc4

make dav4android as submodule

d593474

make propfind operation run without errors

ca2eff6

Remove unneeded slahes in url

a467855

Keep completing the propfind

7cb9189

Register new WebDAV properties in dav4android

68fae46

Create DAVOCResource and http constants file in dav4android

77c7c51

Include user agent in OCContext and start implementing the generic pu…

2ba891d

…t operation

Move webdav path constant and refactor some Remote operation methods

2ef51dd

Implement UploadRemoteFileOperation with dav4droid

75ce8e1

Include upload headers in interceptor and finish upload file operation

63c917c

davigonz added 10 commits September 4, 2018 15:59

Apply requested changes

b0fa6ae

Get mEtag again

7627f75

Send unique ID header for all requests

50fda00

Fix some problems in authentication

e3db308

Prepare wrapper to handle response bodies after exceptions

eb7cac0

Fix antivirus message

d30a557

Fix file downloaded each time is tapped

7823612

Fix credentials in switch accounts

f3eb0c4

Fix follow redirections

8a04392

Fix upload colissions

eaa645a

davigonz force-pushed the replace_network_library branch from ab2cd1a to eaa645a Compare September 4, 2018 14:04

davigonz added 16 commits September 4, 2018 16:44

Fix renewal of OAuth2 token

800c075

Use header constants instead of plain text

cc612f8

Fix remote file creation using username instead of display name

81f1804

Crash when restoring cookies

817e3c8

Include dav4android via jitpack

fef62aa

Remove dav4android subproject

ae7be42

Reimplement cookies handling

f2ccc62

Make cookies handling more efficient

549cc32

Fix SAML with new cookies handling

5d3bba6

Include fix to switch credentials properly

d195b2f

Avoid duplicated cookies

c36a71c

Clean up some dependencies

096d037

Update sample client to use new library

33fd103

Include setup.xml for sample client

8841a0f

Fix bug when restoring SAML cookies after expiring a SAML session

14ec6cb

Fix some downloads by disabling encoding

fabf8d5

davigonz merged commit 2fdf724 into master Oct 9, 2018

JuancaG05 deleted the replace_network_library branch May 30, 2023 14:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace network library #192

Replace network library #192

davigonz commented Jun 7, 2018 •

edited

Loading

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018 •

edited

Loading

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

davigonz Aug 6, 2018

jabarros Aug 9, 2018

davigonz Aug 9, 2018

davigonz Aug 9, 2018

jabarros commented Aug 9, 2018

theScrabi commented Oct 9, 2018

		@@ -31,21 +31,21 @@
		import com.owncloud.android.lib.common.authentication.OwnCloudBasicCredentials;

		@@ -26,19 +26,22 @@
		import com.owncloud.android.lib.common.authentication.OwnCloudBasicCredentials;

		@@ -1,140 +1,138 @@
		/* ownCloud Android Library is available under MIT license
		* Copyright (C) 2016 ownCloud GmbH.

		@@ -1,29 +1,16 @@
		/* ownCloud Android Library is available under MIT license

Replace network library #192

Replace network library #192

Conversation

davigonz commented Jun 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

davigonz Aug 6, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jabarros commented Aug 9, 2018

theScrabi commented Oct 9, 2018

davigonz commented Jun 7, 2018 •

edited

Loading

davigonz Aug 6, 2018 •

edited

Loading