Include federated share activity in sidebar #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
AlexAndBear
requested changes
Jun 23, 2021
jvillafanez
reviewed
Jun 23, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
jvillafanez
approved these changes
Jun 23, 2021
AlexAndBear
approved these changes
Jun 23, 2021
phil-davis
added a commit
that referenced
this pull request
Jun 24, 2021
nightly CI had some test failures. It is probably related to the merging of core owncloud/core#38880 and activity #972 yesterday. This will confirm if there is a test issue here in activity.
This was referenced Jun 24, 2021
Closed
11 tasks
This was referenced Nov 2, 2021
Closed
JammingBen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix, the objectId of a received federated share activity was empty. As a result, the activity was not showing in the file sidebar. We now set the objectId by updating the activity as soon as the share has been accepted by the user.
Also fixed a bug where certain activities were not showing in
Activities by others.fixes [QA] Download activity is missing in
Activities by others#969fixes [QA] Activity when receiving a federated share is missing in sidebar and
Activities by others#970Depends on [full-ci] Trigger file scan after accepting a federated share core#38880