Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharing a files with two users #697

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Sharing a files with two users #697

merged 1 commit into from
Feb 21, 2019

Conversation

bishalrijal
Copy link
Contributor

@bishalrijal bishalrijal commented Feb 4, 2019 •
edited
Loading

Sharing a files with two users acceptance test added
Demonstrating bug for #695

@skshetry skshetry added the bug label Feb 4, 2019
skshetry
skshetry reviewed Feb 5, 2019
View reviewed changes
tests/acceptance/features/webUIActivity/sharingInternal.feature Outdated
And user "user0" has shared file "textfile0.txt" with user "user2"
When user "user0" browses to the activity page
Then the activity number 1 should have a message saying that you have shared file "textfile0.txt" with user "User Two"
And the activity number 2 should have a message saying that you have shared file "textfile0.txt" with user "User One"
Copy link
Member

@skshetry skshetry Feb 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk if this step is a requirement. Maybe this should come as a collection (i.e.. You have shared file "textfile0.txt" with user "User Two" and "User One")?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments below

@skshetry
Copy link
Member

skshetry commented Feb 5, 2019 •
edited
Loading

This seems to be the issue with the parser that generates subject_prepared because, on the activity API, it returns as a collection but doesn't have the former event inside it(in the DB, the event is recorded as seen in oc_activity table).

EDIT: Only a single entry is returned in subject_params in API, so, it might not be bug in Parser.
EDIT: This is not a bug only with webUI. This happens in API as well.

@skshetry
Copy link
Member

skshetry commented Feb 5, 2019

@bishalrijal, please sync the branch with the master. There were recent changes to the used steps.

@codecov
Copy link

codecov bot commented Feb 7, 2019 •
edited
Loading

Codecov Report

Merging #697 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #697   +/-   ##
========================================
  Coverage      83.9%   83.9%           
  Complexity      502     502           
========================================
  Files            45      45           
  Lines          1802    1802           
========================================
  Hits           1512    1512           
  Misses          290     290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab5b88f...76a3ac3. Read the comment docs.

@bishalrijal bishalrijal force-pushed the sharing-files-activity branch 2 times, most recently from 6b008fd to f9f8e7a Compare February 7, 2019 09:51
paurakhsharma
paurakhsharma reviewed Feb 7, 2019
View reviewed changes
Copy link
Member

@paurakhsharma paurakhsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good. 👍

@bishalrijal bishalrijal force-pushed the sharing-files-activity branch from f9f8e7a to cc12247 Compare February 7, 2019 10:20
@individual-it
Copy link
Member

@ownclouders rebase

@individual-it individual-it self-assigned this Feb 8, 2019
@skshetry skshetry force-pushed the sharing-files-activity branch from 3c3e243 to 76a3ac3 Compare February 15, 2019 09:23
@skshetry skshetry requested a review from phil-davis February 20, 2019 10:37
@skshetry
Copy link
Member

@individual-it @phil-davis can you review this?

@individual-it individual-it merged commit b779bc4 into owncloud:master Feb 21, 2019
@individual-it
Copy link
Member

sorry was forgotten

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paurakhsharma paurakhsharma paurakhsharma left review comments

@dpakach dpakach dpakach left review comments

@skshetry skshetry skshetry left review comments

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@individual-it individual-it

Labels
dev:acceptance-tests QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bishalrijal @skshetry @individual-it @dpakach @paurakhsharma